Skip to content

Commit 3b14f6a

Browse files
committed
fix(ecs-task-definition): disable then delete
1 parent 04a7e5d commit 3b14f6a

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

resources/ecs-task-definition.go

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,17 @@ func (r *ECSTaskDefinition) Filter() error {
104104
}
105105

106106
func (r *ECSTaskDefinition) Remove(ctx context.Context) error {
107-
_, err := r.svc.DeregisterTaskDefinition(ctx, &ecs.DeregisterTaskDefinitionInput{
108-
TaskDefinition: r.arn,
107+
if *r.Status != string(ecstypes.TaskDefinitionStatusInactive) {
108+
_, err := r.svc.DeregisterTaskDefinition(ctx, &ecs.DeregisterTaskDefinitionInput{
109+
TaskDefinition: r.arn,
110+
})
111+
if err != nil {
112+
return err
113+
}
114+
}
115+
116+
_, err := r.svc.DeleteTaskDefinitions(ctx, &ecs.DeleteTaskDefinitionsInput{
117+
TaskDefinitions: []string{*r.arn},
109118
})
110119

111120
return err
@@ -115,6 +124,7 @@ func (r *ECSTaskDefinition) Properties() types.Properties {
115124
return types.NewPropertiesFromStruct(r)
116125
}
117126

127+
// TODO(v4): switch to using name property
118128
func (r *ECSTaskDefinition) String() string {
119129
return *r.arn
120130
}

0 commit comments

Comments
 (0)