Skip to content

Commit 5560ce3

Browse files
authored
Fix crash when WAF/WAFRegional GetRule gives error (#894)
1 parent ac386b8 commit 5560ce3

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

resources/waf-rules.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,12 @@ func ListWAFRules(sess *session.Session) ([]Resource, error) {
3232
}
3333

3434
for _, rule := range resp.Rules {
35-
ruleResp, _ := svc.GetRule(&waf.GetRuleInput{
35+
ruleResp, err := svc.GetRule(&waf.GetRuleInput{
3636
RuleId: rule.RuleId,
3737
})
38+
if err != nil {
39+
return nil, err
40+
}
3841
resources = append(resources, &WAFRule{
3942
svc: svc,
4043
ID: rule.RuleId,

resources/wafregional-rules.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,12 @@ func ListWAFRegionalRules(sess *session.Session) ([]Resource, error) {
3434
}
3535

3636
for _, rule := range resp.Rules {
37-
ruleResp, _ := svc.GetRule(&waf.GetRuleInput{
37+
ruleResp, err := svc.GetRule(&waf.GetRuleInput{
3838
RuleId: rule.RuleId,
3939
})
40+
if err != nil {
41+
return nil, err
42+
}
4043
resources = append(resources, &WAFRegionalRule{
4144
svc: svc,
4245
ID: rule.RuleId,

0 commit comments

Comments
 (0)