return non zero code for throttling exceptions even if no new resources are found

Author: corybekk

cmd/nuke.go

@@ -63,6 +63,16 @@ func (n *Nuke) Run() error {
 		return err
 	}
 
+	if n.items.Count(ItemStateFailed) > 0 && n.items.Count(ItemStateNew) == 0 {
+		for _, item := range n.items {
+			if item.State != ItemStateFailed {
+				continue
+			}
+			logrus.Error(fmt.Sprintf("%s. %s.", item.Type, item.Reason))
+		}
+		return fmt.Errorf("failed")
+	}
+
 	if n.items.Count(ItemStateNew) == 0 {
 		fmt.Println("No resource to delete.")
 		return nil
@@ -249,9 +259,9 @@ func (n *Nuke) HandleQueue() {
 			n.HandleRemove(item)
 			item.Print()
 		case ItemStateFailed:
-			// item.Resource will be nil if an exception was thrown while retrieving the resourceType's
-			// items (I.E resourceTypes lister()), however we still pass down the reason and state so we
-			// aren't ignoring these exceptions.
+			// item.Resource will be nil if an exception was thrown while retrieving cloudControl
+			// resourceType's items (I.E resourceTypes lister()), however we still pass down the
+			// reason and state so we aren't ignoring these exceptions.
 			if item.Resource != nil {
 				n.HandleRemove(item)
 				n.HandleWait(item, listCache)

cmd/scan.go

@@ -73,9 +73,6 @@ func (s *scanner) list(region *Region, resourceType string) {
 			return
 		}
 
-		// check for this error "ThrottlingException: Rate exceeded"
-		// TODO: if there is a throttling exception call lister(sess) again 3 times with exponential backoff.
-		// or maybe try recursion and call s.list(region, resourceType)
 		awsErr, ok := err.(awserr.Error)
 		if ok && awsErr.Code() == "ThrottlingException" {
 			s.items <- &Item{
@@ -85,6 +82,8 @@ func (s *scanner) list(region *Region, resourceType string) {
 				Reason:   err.Error(),
 				Type:     resourceType,
 			}
+			dump := util.Indent(fmt.Sprintf("%v", err), "    ")
+			log.Errorf("Listing %s failed:\n%s", resourceType, dump)
 			return
 		}