Bug fix: part IDs now refer to the correct part

Also, a little further cleanup in test_file_processing that I noticed
while looking for the parts tests

Author: delfanbaum

jupyter_book_to_htmlbook/file_processing.py

@@ -37,10 +37,12 @@ def process_part(part_path: Path, output_dir: Path):
         part_number = info.group(1)
         # undo earlier space replacement and do a simple title case
         part_name = info.group(2).replace('-', ' ')
+        # just to make the string fit better
+        ns = "http://www.w3.org/1999/xhtml"
 
         with open(output_dir / f'part-{part_number}.html', 'wt') as f:
             f.write(f"""
-<div xmlns="http://www.w3.org/1999/xhtml" data-type="part" id="part-1">
+<div xmlns="{ns}" data-type="part" id="part-{part_number}">
 <h1>{part_name}</h1>
 </div>""".lstrip())
         return f'part-{part_number}.html'

tests/test_file_processing.py

@@ -29,7 +29,7 @@ def test_compile_chapter_parts_happy_path(self, tmp_book_path):
         number_of_sections_expected = 2  # the first html file doesn't get one
         assert number_of_sections == number_of_sections_expected
 
-    def test_process_chapter_single_chapter_file(self, tmp_book_path, capsys):
+    def test_process_chapter_single_chapter_file(self, tmp_book_path):
         """
         happy path for chapter processing a single chapter file
 
@@ -161,7 +161,7 @@ def test_process_chapter_with_subfiles(self, tmp_book_path):
         assert "ch02" in result
         assert os.path.exists(test_out / 'ch02.00.html')
 
-    def test_process_chapter_with_subsections(self, tmp_book_path, capsys):
+    def test_process_chapter_with_subsections(self, tmp_book_path):
         """
         ensure subsections are getting data-typed appropriately
         """
@@ -315,7 +315,7 @@ def test_process_chapter_appendix_datatypes(self, tmp_path):
             text = f.read()
             assert text.find('data-type="appendix"') > -1
 
-    def test_process_appendix_with_subsections(self, tmp_path, capsys):
+    def test_process_appendix_with_subsections(self, tmp_path):
         """
         ensure subsections are getting data-typed appropriately when
         they're a part of an appendix

tests/test_part_processing.py

@@ -26,3 +26,14 @@ def test_process_part_bad_name(self, tmp_path, caplog):
         result = process_part(part_path, tmp_path)
         assert result is None
         assert "unable to parse part information" in caplog.text.lower()
+
+    def test_process_part_id_is_correct(self, tmp_path):
+        """
+        Sanity check test to confirm that a prior bug isn't (re)introduced
+        """
+        part_path = Path(tmp_path / '_jb_part-20-Part.html')
+        result = process_part(part_path, tmp_path)
+        assert result == 'part-20.html'
+        with open(tmp_path / 'part-20.html') as f:
+            text = f.read()
+            assert text.find('id="part-20"') > 0