Remove Luxcoreui nativefiledialog dependency
#978
Replies: 3 comments 2 replies
-
|
No objections to replacing the dependency. With respect to your already made proposal to replace luxcoreui with a python-based alternative, I would suggest to pick whatever is easiest to implement, if it makes any difference, and without too much concern for support periods. We should understand and chart the current features of luxcoreui (might be documented in the wiki), then draft a concept for a new python GUI. With that, we can define a timeline when it should be available. |
Beta Was this translation helpful? Give feedback.
-
|
@howetuft Reviewing if this Discussion can be closed or should remain open. I don't see any references to |
Beta Was this translation helpful? Give feedback.
-
|
Yes we can close! |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Remove
nativefiledialogdependency fromluxcoreuiProposal overview
This is a proposal to replace
nativefiledialog, inluxcoreui, by a lighter file dialog provider.Rationale
luxcoreuirelies onImGuiframework for its graphical interface. However,ImGuidoes not provide any file dialog (well-known drawback...), so a dedicated dependency, callednativefiledialog, was introduced inluxcoreuito remedy.Problem is
nativefiledialogrequiresgtk3as a dependency, with several consequences:gtk3is a "system" dependency, meaning that Conan (logically) does not provide any source recipe nor precompiled version, but relies on system packages. It can lead to ABI incompatibility and crashes, when compiling on a platform and running on another.gtk3binaries with luxcoreui, it leads to a bunch of embedded shared libs, some of them having very little relationship with luxcoreui (like sound libs etc.). Moreover, Cmake standard dependency installer mainly focuses on direct deps, which leaves the problem open for indirect deps.luxcoreuifrom running in a containerized environment (snap etc.), as gtk3 libraries access are restricted in such an env.Candidates are:
imgui-filebrowser
imguiFileDialog, from ospray Studio
Beta Was this translation helpful? Give feedback.
All reactions