GitHub can't render diffs for indexed images (Test.Method#01.verified.jpg)

[simonmckenzie]

This is more a heads-up than anything - I've found that GitHub can't render diffs for images that follow Verify's indexed filename structure - it seems to incorrectly parse the file name when loading the visual diff.

I have made a repro that shows this issue - while the file names don't look quite like verify's (I wanted to keep it general), it definitely affects verify-style filenames, e.g. MyTests.VerifySomething#00.verified.jpg.

Repro here: https://github.com/simonmckenzie-DEECA/github-cannot-show-diff-for-files-containing-the-hash-character/pull/1/files

I have also raised a support ticket with GitHub about this, so hopefully they'll fix it. I can't share the ticket since their ticketing system is private, but here's the core of it:

[SimonCropp]

@simonmckenzie thanks for the heads up. let me know how you go with the support ticket

[simonmckenzie]

Well, they closed my support ticket because I didn't have an important enough access level, so I've raised it as a discussion instead:

https://github.com/orgs/community/discussions/187411