How to solve code review issues on Github?

[callmetango]

This discussion is about how to solve the code review issues experienced by @stefan11111 on Github. Here are the relevant excerpts of the conversation:

---

@stefan11111 commented in X11Libre/xserver#399 (comment):

For some reason, github doesn't let me ask for review.
Either that, or I don't know how to do it.
Here's a ping instead, what is your opinion on this pr?

---

@callmetango commented in X11Libre/xserver#399 (comment):

@callmetango any idea on that github issue ? some special settings needed ?

Sounds strange to me. Normally @stefan11111 should have all the required permissions by being in the same group as the others are too.

Maybe he is missing some repository specific permissions?

Some background: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review

@stefan11111 Are you trying to do this: Assign yourself as a reviewer of your own pull request · community · Discussion #6292 ?

---

@stefan11111 commented in X11Libre/xserver#399 (comment):

@callmetango any idea on that github issue ? some special settings needed ?

Sounds strange to me. Normally @stefan11111 should have all the required permissions by being in the same group as the others are too.
Maybe he is missing some repository specific permissions?
Some background: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review

I tried doing that, but for some reason I couldn't. I don't see that menu where I could click request do add a reviewer.

---

@metux commented in X11Libre/xserver#399 (comment):

@metux @dec05eba @mikedld For some reason, github doesn't let me ask for review. Either that, or I don't know how to do it. Here's a ping instead, what is your opinion on this pr?

maybe needs extra permissions ? if anybody can tell me what exactly I'll have to do, I'd be happy to add them

---

@metux commented in X11Libre/xserver#399 (comment):

I tried doing that, but for some reason I couldn't. I don't see that menu where I could click request do add a reviewer. [...]

It doesn't work for me either

I've been believing that all org members can do that. Am I wrong and we need extra permissions ?

[callmetango]

@stefan11111 Do you still have these problems?