Link is already in database question

[jimojeda]

First of all, thank you for this amazing piece of software, I absolutely LOVE YOURLS!

Just one question that I haven't seen answered.

Whenever someone tries to create a short link and the target URL is already in the database, it warns that the target link is already in the database.

I know I can update the config file to turn off unique links.

But would it be possible instead to have YOURL say something like...

There already is a short link for that destination URL which is: [short link here]

That way, I don't have to worry that there are too many repetitive links in the database because I don't need too many links going to the same destination URL, know what I mean?

[dgw]

know what I mean?

Not really. Either you want to allow multiple shortlinks to the same target, or not, and in either case you can search in the admin interface for all or part of the long URL to find what shortlinks exist for it.

What am I missing? Is this a feature request for a "YOURLS_UNIQUE_URLS_UNLESS_I_SAY_OTHERWISE" setting that will show you the existing keyword the first time you try to re-shorten a link but create a new one if you try again/specify a keyword/something else?

[jimojeda]

Correct... I don't want to allow multiple shortlinks to the same target URL.

So when you try to create a shortlink, if there's already a shortlink to that target URL, it should come back with a message like, "There's already a shortlink to that destination URL in the database. Here's that link: https://example.com/short"

That way, I can use the shortened link that already exists instead of creating new ones each time that go to a destination URL that is already in the database.

I know that my installation is set like that already. It's "unique links" feature is activated.

All I'm saying is that I'd like for the code to reveal the shortlink to the user trying to shorten a link to a target URL that already exists.

Does that make sense? (and please forgive me if I'm not wording things right.)

[dgw]

Ah, this is purely a front-end enhancement, though could be reflected in how the back-end returns the error if other maintainers like the idea.

Shouldn't be a big deal for anyone who knows basic JavaScript to patch it in here:

YOURLS/js/insert.js

Lines 27 to 58 in 42fd3b8

	// Create new link and add to table
	function add_link() {
	if( $('#add-button').hasClass('disabled') ) {
	return false;
	}
	var newurl = $("#add-url").val();
	var nonce = $("#nonce-add").val();
	if ( !newurl || newurl == 'http://' || newurl == 'https://' ) {
	return;
	}
	var keyword = $("#add-keyword").val();
	add_loading("#add-button");
	$.getJSON(
	ajaxurl,
	{action:'add', url: newurl, keyword: keyword, nonce: nonce},
	function(data){
	if(data.status == 'success') {
	$('#main_table tbody').prepend( data.html ).trigger("update");
	$('#nourl_found').css('display', 'none');
	zebra_table();
	increment_counter();
	toggle_share_fill_boxes( data.url.url, data.shorturl, data.url.title );
	}
	add_link_reset();
	end_loading("#add-button");
	end_disable("#add-button");
	feedback(data.message, data.status);
	}
	);
	}

since the AJAX response should already contain the required info:

YOURLS/includes/functions-shorturls.php

Lines 129 to 140 in 42fd3b8

	// URL was already stored
	} else {
	yourls_do_action( 'add_new_link_already_stored', $url, $keyword, $title );
	$return['status'] = 'fail';
	$return['code'] = 'error:url';
	$return['url'] = array( 'keyword' => $url_exists->keyword, 'url' => $url, 'title' => $url_exists->title, 'date' => $url_exists->timestamp, 'ip' => $url_exists->ip, 'clicks' => $url_exists->clicks );
	$return['message'] = /* //translators: eg "http://someurl/ already exists" */ yourls_s( '%s already exists in database', yourls_trim_long_string( $url ) );
	$return['title'] = $url_exists->title;
	$return['shorturl'] = yourls_link($url_exists->keyword);
	}