Argument versioning_enabled not expected on spa-s3-cloudfront component

[ronaldsteen]

The spa-s3-cloudfront component uses the cloudfront-s3-cdn module.
From version 1.0.0 the variable versioning_enabled is no longer available on the module.

This results in the following error:

│ Error: Unsupported argument
│ 
│   on main.tf line 85, in module "spa_web":
│   85:   versioning_enabled                 = var.origin_versioning_enabled
│ 
│ An argument named "versioning_enabled" is not expected here.

Code from the component:

module "spa_web" {
  source  = "cloudposse/cloudfront-s3-cdn/aws"
  version = "1.0.0"

  block_origin_public_access_enabled = local.block_origin_public_access_enabled
  encryption_enabled                 = var.origin_encryption_enabled
  origin_force_destroy               = var.origin_force_destroy
  versioning_enabled                 = var.origin_versioning_enabled

 ...
}

[milldr]

Yes, that’s correct. the versioning_enabled input was deprecated in the cloudfront-s3-cdn module and should be removed from the component. Versioning is now managed directly on the S3 origin bucket when it’s provisioned, so there’s no longer a separate flag to toggle it at the module level.

Feel free to remove that argument from the component.

[ronaldsteen]

Made a PR here that reflects this change.