[discourse] Disable log for grpc.health.v1.Health

[markphelps]

Originally posted by lpaquet on Discourse

Hello !

We are flooded by those logs:

INFO        finished unary call with code OK        {"server": "grpc", "grpc.start_time": "2024-06-12T14:17:34Z", "system": "grpc", "span.kind": "server", "grpc.service": "grpc.health.v1.Health", "grpc.method": "Check", "peer.address": ....

Do you know if there is a way to disable them ? (besides putting log level to ERROR)

Many thanks for your help !

Ludovic

[dosubot[bot]]

I couldn't find any configuration options or documentation in Flipt to disable logs specifically for grpc.health.v1.Health without changing the global log level. There are no existing tickets or discussions about this either. It looks like Flipt currently logs all gRPC calls at the INFO level, including health checks, and there isn't a built-in way to filter out just the health check logs. If you need more granular control, it may require a code change to add filtering for specific gRPC services. If you have any custom logging setup or use a log processor, you might be able to filter these logs downstream as a workaround. Let me know if you want more details on possible code changes or log filtering strategies.

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}   

[markphelps]

Reply from mark on Discourse:

lpaquet:

Do you know if there is a way to disable them ? (besides putting log level to ERROR)

Hi @lpaquet ! You can set the GRPC log level independent of the application log level (logs that we output from Flipt itself).

For example log.grpc_level can be set to ERROR while log.level can still be set to INFO.

Does that help?

[markphelps]

Reply from lpaquet on Discourse:

Thx, gonna try but I thought error was the default as stated here:

  <a href="https://docs.flipt.io/configuration/overview#logging" target="_blank" rel="noopener nofollow ugc">Flipt</a>

Overview - Flipt

This document describes how to configure the Flipt server.

[markphelps]

Reply from lpaquet on Discourse:

Indeed, I’ve missed something obviously, even with

log:
  grpc_level: error

We’re still having those logs.

Putting

log:  
  level: error
  grpc_level: error

it’s ok. Too bad to have to increase log level just for the healthcheck don’t you think ?

[markphelps]

Reply from mark on Discourse:

Yes I think you are right, it is a bit silly to log the healthcheck requests

It seems we can skip the healthcheck from being logged using a Decider function when setting up our GRPC log

I will implement this and have it in the next release.

I don’t believe anyone would depend on these healthcheck logs, so I don’t think we need to make it configurable

[markphelps]

Reply from lpaquet on Discourse:

Totally agree, many thx Mark !

[markphelps]

Reply from mark on Discourse:

New release (v1.44.0) is getting released now that will have this fix in it! Please let me know if it solves the issue

[markphelps]

Reply from lpaquet on Discourse:

Thx, gonna check next week, I’ll tell you

[markphelps]

Reply from lpaquet on Discourse:

Shame on me, sry to answer this so lately. Indeed it has been fixed !