Request for review: Terraform provider PR #7 – fix import for langfuse_organization_membership #11656
-
Describe your questionHi Langfuse team 👋 Problem: The resource needs org credentials to read the membership, but the current ImportState uses passthrough ID and doesn’t support providing the required keys during import. What this PR changes: Implements custom ImportState parsing an import ID in the format: Validates credentials by fetching the membership from the API Sets all state attributes via resp.State.Set() for proper initialization Adds unit tests covering success + invalid formats + API error handling Would someone be able to review / advise if this import ID format is acceptable (or if you prefer a different approach)? Langfuse Cloud or Self-Hosted?Self-Hosted If Self-Hosted3.147.0 If Langfuse CloudNo response SDK and integration versionsNo response Pre-Submission Checklist
|
Beta Was this translation helpful? Give feedback.
Replies: 1 comment
-
|
Hey @benc-vorwerk, |
Beta Was this translation helpful? Give feedback.
Hey @benc-vorwerk,
Thank you so much! Feel free to tag or assign me to provider PRs going forward. Will take a look and move the communication there!