Nested sub-routes question

[kczx3]

Can you provide an explanation of the valid routes that the second example on the Sub-routing documentation page would provide? I fear I am not understanding the intended effect of it. At the time of this writing, below is the example code I am referring to. I have added comments mimicking the first example with my understanding and what actually happens.

$app->group('/user', function () use($app) {
  // will result in '/user/'
  $app->get('/', function () use($app) {
    $app->response()->markup('no user id');
  });

  // will result in '/user/12'
  $app->get('/(\d+)', function ($id) use($app) {
    $app->response()->markup("user $id");
  });

  // I would have thought this would correspond to '/user/settings'
  // However, this actually mounts onto the root path '/settings/'
  $app->mount('/settings', function () use($app) {
    // will result in '/settings/privacy' when I expected '/user/settings/privacy'
    $app->get('/privacy', function () use($app) {
      $app->response()->markup('Privacy Settings');
    });

    // will result in '/settings/notification' when I expected '/user/settings/notification'
    $app->get('/notification', function () use($app) {
      $app->response()->markup("Notification Settings");
    });
  });
});

[kczx3]

If this works as intended and not how I imagine then perhaps it would be nice to pass the current route path into the callback function that you pass into $app->group().

$app->group('/user', function () use($app, $routePrefix1) {
  // $routePrefix1 would be equal to '/user' here
  // I would have thought this would correspond to '/user/settings'
  // However, this actually mounts onto the root path '/settings/'
  $app->mount("$routePrefix1/settings", function () use($app, $routePrefix2) {
    // $routePrefix2 would be equal to '/user/settings' here however in this case it is not needed
    // will result in '/settings/privacy' when I expected '/user/settings/privacy'
    $app->get('/privacy', function () use($app) {
      $app->response()->markup('Privacy Settings');
    });
  });
});

[mychidarko]

@kczx3 I thought I had replied to this thread. This is actually a bug, the behaviour you expected is the right one.

[mychidarko]

It's been fixed now, so you can update Leaf and your issue should be fixed

[kczx3]

Thanks! You replied on Discord but I think there was some misunderstanding. The wording in the docs about nested routes not supporting dynamic url patterns is confusing. You might consider re-wording it or providing an example of what doesn't work in addition to the existing sample of what you can do.

[kczx3]

@mychidarko I'm not sure that this is resolved 100%. Nested group routes only work for the first sub-group. Take the following example:

$app->group('/test', function() {
    app()->get('/', fn() => response()->plain('test root'));

    app()->group('/one', function () {
        app()->get('/', fn() => response()->plain('test/one'));
    });

    app()->group('/two', function () {
        app()->get('/', fn() => response()->plain('test/two'));
    });
});

After this, app()->routes() returns the following:

Shouldn't the last route be mounted onto /test/two?

[mychidarko]

Let me check this out. Might be some funny logic

[mychidarko]

It's been fixed @kczx3