Thunderbolt module in Cinnamon Settings

[timfeierabend]

I've built a simple Thunderbolt device settings page for Cinnamon Settings. It uses boltd to show known Thunderbolt devices, authenticate them, and trust/forget them. I'd like to contribute this to the Cinnamon project somehow - I don't know what the next steps would be.

You can get the module code here: https://raw.githubusercontent.com/timfeierabend/cinnamon/refs/heads/thunderbolt-settings/files/usr/share/cinnamon/cinnamon-settings/modules/cs_thunderbolt.py

Rationale

When I started using Linux Mint, I immediately appreciated how much effort went into the stability and usability of Cinnamon and the various Linux Mint apps. I was surprised to learn that I needed to open a terminal and issue boltctl commands to enable my docking station. Some quick research showed functionality was present in both GNOME (via GNOME Control Center) and KDE (via KDE Settings w/ plasma-thunderbolt package).

Many laptops are powered by Intel processors, with the higher end ones having at least 1 Thunderbolt port. Adding this feature will improve the usability for Cinnamon for less-technical users and make Cinnamon feel more complete.

TO-DO

• Create a .desktop file so this setting can be opened from Cinnamon Menu > Preferences Done!
• Add a section or message when no devices are known so users aren't confused when the page is empty
• (Opinion) This module shouldn't be available/usable on systems without Thuderbolt. Maybe its an addon package included during installation if Thunderbolt is present? Done!
• Translations

Any and all feedback on this is welcome!

[timfeierabend]

UPDATE

Re-designed the settings UI to be simpler, with expandable details section.

Details expanded:

I've grabbed the Thunderbolt icon from Papirus project to use for this settings module.

Start Menu:

Settings:

Working on final package testing locally. Will upload to a new cinnamon-thunderbolt repository soon.

[timfeierabend]

UPDATE

Repo for cinnamon-thunderbolt is live: https://github.com/timfeierabend/cinnamon-thunderbolt/tree/master

@clefebvre @mtwebster I'd like to submit this package to the Cinnamon project. I know this is not a simple pull request and this my first Debian package. If this isn't the correct way to do this, let me know. I'm open to all thoughts and feedback. Thanks!

[mtwebster]

I think it's ok to have it appear in cinnamon settings, and the menu, even if there's no support.

There are a few precedents:

• Gestures
• Drawing tablets
• Color is useless for 95% of users
• Bluetooth - desktops typically don't have this (at least none of mine do)

I'd definitely prefer this just be part of Cinnamon in its current form. If the user selects the module, it can check for support then, and display a message and hide the controls if there is none (or no devices?)

[Fantu]

@mtwebster Thanks for reply, I'm not sure if you would accept the inclusion inside cinnamon source (if good).

@timfeierabend I have not reviewed the code but from a fast look I spotted from gi.repository import * that I think "*" is bad, should include only the specific things really needed, and if I'm not wrong with this make more difficult to understand missed required packages to install

[timfeierabend]

Thank you both @mtwebster and @Fantu for your feedback - let me work this feedback into a pull request. I'll add a message banner at the top of the page that I'll use to display warnings and other messages.

[mtwebster]

@timfeierabend I have not reviewed the code but from a fast look I spotted from gi.repository import * that I think "*" is bad

Agreed

I'll add a message banner at the top of the page that I'll use to display warnings and other messages.

For situations like this we think it's cleaner just to have a large symbolic icon and a message under it in the middle of the 'window' -

Warpinator when there's no network, or

Gestures when they're disabled -

No drawing tablet detected (I'm going to fix this oversized icon!!):

If for some reason we decide not to include the bolt package a button could be put there also to install it (for now I'd work on the assumption it will be)

[timfeierabend]

Thanks again @mtwebster and @Fantu for your feedback! I refactored the whole settings module, added some additional pages for no devices and missing dependencies, and submitted a pull request.