node DB overflow possible?

[shalberd]

@thebentern

https://meshtastic.org/blog/that-one-time-at-defcon/

"When a node is marked as a favorite, it is never cycled out of the NodeDB. "
"Nodes are automatically favorited when a DM is sent to that node, or when users share contacts via QR code."

What happens when there are more than 80 favorites on e.g. an NRF / RAK Node?

Which firmware does the blog post refer to?

[thebentern]

Favoriting a node excludes it from rolling off the NodeDB buffer. When the NodeDB buffers gets "full", we start to roll off nodes that are deemed less interesting (older, without keys, etc). For NRF nodes indeed the current max is 80:
https://github.com/meshtastic/firmware/blob/develop/src/mesh/mesh-pb-constants.h#L26
An important thing to remember is that the favorite feature protects those nodes from the reclamation process and that ANY node in the nodedb has immutable keys for as long as it exists in the nodedb. This is why it is important to keep your known contacts favorited, to preserve them and ensure this sort of attack.

The defcon specific firmware has some customizations for the event and is served at:
https://defcon.meshtastic.org/

[shalberd]

Nodes are automatically favorited when a DM is sent to that node, or when users share contacts via QR code.

Ok, so that only applies to the DefCon firmware, good and reassuring to know.