Error generating mpy-cross for v.1.22.2 RP2040 port - in module gc.c that involves MICROPY_GC_HOOK_LOOP

[rcalcagno]

I am getting an error when building mpy-cross, when reaching the module gc.c. This is the output:

3.839   410 |             MICROPY_GC_HOOK_LOOP(i);
3.839       |                                 ^
3.839 ../py/gc.c: In function 'gc_deal_with_stack_overflow':
3.839 ../py/gc.c:466:37: error: statement with no effect [-Werror=unused-value]
3.839   466 |                 MICROPY_GC_HOOK_LOOP(block);
3.839       |                                     ^
3.840 ../py/gc.c: In function 'gc_sweep':
3.840 ../py/gc.c:498:33: error: statement with no effect [-Werror=unused-value]
3.840   498 |             MICROPY_GC_HOOK_LOOP(block);
3.840       |                                 ^
3.840 ../py/gc.c: In function 'gc_collect_root':
3.840 ../py/gc.c:608:29: error: statement with no effect [-Werror=unused-value]
3.840   608 |         MICROPY_GC_HOOK_LOOP(i);
3.840       |                             ^
3.841 ../py/gc.c: In function 'gc_info':
3.841 ../py/gc.c:666:33: error: statement with no effect [-Werror=unused-value]
3.841   666 |             MICROPY_GC_HOOK_LOOP(block);
3.841       |                                 ^
3.842 ../py/gc.c: In function 'gc_alloc':
3.842 ../py/gc.c:774:37: error: statement with no effect [-Werror=unused-value]
3.842   774 |                 MICROPY_GC_HOOK_LOOP(i);
3.842       |                                     ^
4.016 cc1: all warnings being treated as errors
4.018 -e See https://github.com/micropython/micropython/wiki/Build-Troubleshooting
4.018 make: *** [../py/mkrules.mk:90: build/py/gc.o] Error 1
4.018 make: Leaving directory '/micropython/mpy-cross' 

This doesn't happen in version 1.20.0 and before; only from version 1.21.0 and up. Any help is really appreciated.

Sincerely,

Ricardo

[dlech]

Maybe gc.c needs explicit #include "py/mpconfig.h"?

Or did you define MICROPY_GC_HOOK_LOOP somewhere in your own code?

[rcalcagno]

....I know what could be happening. I am using a customized banner by modifying mpconfig.h that's from....yes, version 1.20. Makes sense that some definitions need to be updated. Will try with a mpconfig.h that's also from v1.22.2 and see what happens.

Thank you very much! Sincerely,

Ricardo.

EDIT Tried with unmodified mpconfig.h and worked as a charm. Thanks a lot again!

[dlech]

Ah, that would do it. FYI, mpconfig.h is not meant to be edited directly, but rather use mpconfigboard.h if you have a custom board.

[dlech]

For the banner though, you could proably just use make ... CFLAGS_EXTRA='-DMICROPY_BANNER_MACHINE="..."' or do something similar in the cmake config.

[rcalcagno]

Ah! Good to know! As you might've figured out by now, compiling C code and using GCC are not my particulary strong points! :)

Thank you very much