QSTR not found

[TsXor]

According to https://github.com/jimmo/micropython/blob/framebuf_utils_v2/examples/natmod/framebuf_utils/framebuf_utils.c , I tried to import some modules in a natmod:

# include "py/dynruntime.h"

mp_obj_type_t *mp_FileIO_ptr;
mp_obj_t mp_function_FileIO_seek;
mp_obj_t mp_function_FileIO_read;
mp_obj_type_t *mp_font_t_ptr;

#define MP_IMPORT_MODULE(mname) mp_obj_t mp_mod##mname = mp_import_name(MP_QSTR_##mname, mp_const_none, 0);
#define MP_GETATTR(name, attr) mp_obj_t mp_##attr = mp_load_attr(name, MP_QSTR_##attr);
#define MP_GET_BOUND_METHOD(name, attr) mp_obj_t meth_##attr[2]; \
                                        mp_load_method(mp_##name, MP_QSTR_##attr, meth_##attr); \
                                        mp_obj_t mp_##name##_##attr = meth_##attr[0];

mp_obj_t mpy_init(mp_obj_fun_bc_t *self, size_t n_args, size_t n_kw, mp_obj_t *args) {
    MP_DYNRUNTIME_INIT_ENTRY

	MP_IMPORT_MODULE(lvgl)
	MP_GETATTR(modlvgl, font_t)
	mp_font_t_ptr = MP_OBJ_TO_PTR(mp_font_t);
	
	MP_IMPORT_MODULE(uio)
	MP_GETATTR(moduio, FileIO)
	mp_FileIO_ptr = MP_OBJ_TO_PTR(mp_FileIO);
	MP_GET_BOUND_METHOD(FileIO, seek)
	mp_function_FileIO_seek = mp_FileIO_seek;
	MP_GET_BOUND_METHOD(FileIO, read)
	mp_function_FileIO_read = mp_FileIO_read;

    MP_DYNRUNTIME_INIT_EXIT
}

but I got many errors, indicating the compiler cannot find qstrs:

root@DellBlack:/mnt/f/Users/23Xor/Desktop/esp/HoloCubic-MicroPython-Utils/natmod/myfont# make
GEN build/myfont.config.h
CC myfont.c
In file included from myfont.c:1:
myfont.c: In function 'mpy_init':
myfont.c:8:73: error: 'MP_QSTR_lvgl' undeclared (first use in this function); did you mean 'MP_QSTR_eval'?
 #define MP_IMPORT_MODULE(mname) mp_obj_t mp_mod##mname = mp_import_name(MP_QSTR_##mname, mp_const_none, 0);
                                                                         ^~~~~~~~
../../../lv_micropython/py/dynruntime.h:221:32: note: in definition of macro 'mp_import_name'
     (mp_fun_table.import_name((name), (fromlist), (level)))
                                ^~~~
myfont.c:17:2: note: in expansion of macro 'MP_IMPORT_MODULE'
  MP_IMPORT_MODULE(lvgl)
  ^~~~~~~~~~~~~~~~
myfont.c:8:73: note: each undeclared identifier is reported only once for each function it appears in
 #define MP_IMPORT_MODULE(mname) mp_obj_t mp_mod##mname = mp_import_name(MP_QSTR_##mname, mp_const_none, 0);
                                                                         ^~~~~~~~
../../../lv_micropython/py/dynruntime.h:221:32: note: in definition of macro 'mp_import_name'
     (mp_fun_table.import_name((name), (fromlist), (level)))
                                ^~~~
myfont.c:17:2: note: in expansion of macro 'MP_IMPORT_MODULE'
  MP_IMPORT_MODULE(lvgl)
  ^~~~~~~~~~~~~~~~
myfont.c:18:13: error: 'modlvgl' undeclared (first use in this function); did you mean 'mp_modlvgl'?
  MP_GETATTR(modlvgl, font_t)
             ^~~~~~~
../../../lv_micropython/py/dynruntime.h:187:68: note: in definition of macro 'mp_load_attr'
 #define mp_load_attr(base, attr)          (mp_fun_table.load_attr((base), (attr)))
                                                                    ^~~~
myfont.c:18:2: note: in expansion of macro 'MP_GETATTR'
  MP_GETATTR(modlvgl, font_t)
  ^~~~~~~~~~
myfont.c:9:72: error: 'MP_QSTR_font_t' undeclared (first use in this function); did you mean 'MP_QSTR_const'?
 #define MP_GETATTR(name, attr) mp_obj_t mp_##attr = mp_load_attr(name, MP_QSTR_##attr);
                                                                        ^~~~~~~~
../../../lv_micropython/py/dynruntime.h:187:76: note: in definition of macro 'mp_load_attr'
 #define mp_load_attr(base, attr)          (mp_fun_table.load_attr((base), (attr)))
                                                                            ^~~~
myfont.c:18:2: note: in expansion of macro 'MP_GETATTR'
  MP_GETATTR(modlvgl, font_t)
  ^~~~~~~~~~
myfont.c:8:73: error: 'MP_QSTR_uio' undeclared (first use in this function); did you mean 'MP_QSTR_id'?
 #define MP_IMPORT_MODULE(mname) mp_obj_t mp_mod##mname = mp_import_name(MP_QSTR_##mname, mp_const_none, 0);
                                                                         ^~~~~~~~
../../../lv_micropython/py/dynruntime.h:221:32: note: in definition of macro 'mp_import_name'
     (mp_fun_table.import_name((name), (fromlist), (level)))
                                ^~~~
myfont.c:21:2: note: in expansion of macro 'MP_IMPORT_MODULE'
  MP_IMPORT_MODULE(uio)
  ^~~~~~~~~~~~~~~~
myfont.c:22:13: error: 'moduio' undeclared (first use in this function); did you mean 'mp_moduio'?
  MP_GETATTR(moduio, FileIO)
             ^~~~~~
../../../lv_micropython/py/dynruntime.h:187:68: note: in definition of macro 'mp_load_attr'
 #define mp_load_attr(base, attr)          (mp_fun_table.load_attr((base), (attr)))
                                                                    ^~~~
myfont.c:22:2: note: in expansion of macro 'MP_GETATTR'
  MP_GETATTR(moduio, FileIO)
  ^~~~~~~~~~
myfont.c:9:72: error: 'MP_QSTR_FileIO' undeclared (first use in this function); did you mean 'MP_QSTR_clear'?
 #define MP_GETATTR(name, attr) mp_obj_t mp_##attr = mp_load_attr(name, MP_QSTR_##attr);
                                                                        ^~~~~~~~
../../../lv_micropython/py/dynruntime.h:187:76: note: in definition of macro 'mp_load_attr'
 #define mp_load_attr(base, attr)          (mp_fun_table.load_attr((base), (attr)))
                                                                            ^~~~
myfont.c:22:2: note: in expansion of macro 'MP_GETATTR'
  MP_GETATTR(moduio, FileIO)
  ^~~~~~~~~~
myfont.c:11:67: error: 'MP_QSTR_seek' undeclared (first use in this function); did you mean 'MP_QSTR_sep'?
                                         mp_load_method(mp_##name, MP_QSTR_##attr, meth_##attr); \
                                                                   ^~~~~~~~
../../../lv_micropython/py/dynruntime.h:188:78: note: in definition of macro 'mp_load_method'
 #define mp_load_method(base, attr, dest)  (mp_fun_table.load_method((base), (attr), (dest)))
                                                                              ^~~~
myfont.c:24:2: note: in expansion of macro 'MP_GET_BOUND_METHOD'
  MP_GET_BOUND_METHOD(FileIO, seek)
  ^~~~~~~~~~~~~~~~~~~
myfont.c:8:42: error: unused variable 'mp_moduio' [-Werror=unused-variable]
 #define MP_IMPORT_MODULE(mname) mp_obj_t mp_mod##mname = mp_import_name(MP_QSTR_##mname, mp_const_none, 0);
                                          ^~~~~~
myfont.c:21:2: note: in expansion of macro 'MP_IMPORT_MODULE'
  MP_IMPORT_MODULE(uio)
  ^~~~~~~~~~~~~~~~
myfont.c:8:42: error: unused variable 'mp_modlvgl' [-Werror=unused-variable]
 #define MP_IMPORT_MODULE(mname) mp_obj_t mp_mod##mname = mp_import_name(MP_QSTR_##mname, mp_const_none, 0);
                                          ^~~~~~
myfont.c:17:2: note: in expansion of macro 'MP_IMPORT_MODULE'
  MP_IMPORT_MODULE(lvgl)
  ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make: *** [../../../lv_micropython/py/dynruntime.mk:135: build/myfont.o] Error 1

[TsXor]

It nearly broke my mind that things went wrong in mpy_ld.py!

# include "py/dynruntime.h"

mp_obj_type_t *mp_FileIO_ptr;
mp_obj_t mp_function_FileIO_seek;
mp_obj_t mp_function_FileIO_read;
mp_obj_type_t *mp_font_t_ptr;

#define MP_IMPORT_MODULE(mname) mp_obj_t mp_mod##mname = mp_import_name(MP_QSTR_##mname, mp_const_none, 0);
#define MP_GETATTR(name, attr) mp_obj_t mp_##attr = mp_load_attr(mp_##name, MP_QSTR_##attr);
#define MP_GET_BOUND_METHOD(name, attr) mp_obj_t meth_##attr[2]; \
                                        mp_load_method(mp_##name, MP_QSTR_##attr, meth_##attr); \
                                        mp_obj_t mp_##name##_##attr = meth_##attr[0];

mp_obj_t mpy_init(mp_obj_fun_bc_t *self, size_t n_args, size_t n_kw, mp_obj_t *args) {
    MP_DYNRUNTIME_INIT_ENTRY

	MP_IMPORT_MODULE(lvgl) // MP_QSTR_lvgl
	MP_GETATTR(modlvgl, font_t) // MP_QSTR_font_t
	mp_font_t_ptr = MP_OBJ_TO_PTR(mp_font_t);
	
	
	MP_IMPORT_MODULE(uio) // MP_QSTR_uio
	MP_GETATTR(moduio, FileIO) // MP_QSTR_FileIO
	mp_FileIO_ptr = MP_OBJ_TO_PTR(mp_FileIO);
	MP_GET_BOUND_METHOD(FileIO, seek) // MP_QSTR_seek
	mp_function_FileIO_seek = mp_FileIO_seek;
	MP_GET_BOUND_METHOD(FileIO, read) // MP_QSTR_read
	mp_function_FileIO_read = mp_FileIO_read;

    MP_DYNRUNTIME_INIT_EXIT
}

This piece of code will build successfully because of these comments!

Let's see the critical line in mpy_ld.py:

m = re.search(r"MP_QSTR_[A-Za-z0-9_]*", line)

Yes, no preprocessing, it is just the python script searching for MP_QSTR_* and put it in build/modulename.config.h!
My macro for convenience broke that, but a comment is enough to fix it!

[jimmo]

That's right -- native modules use a much simpler version of QSTR extraction compared to the regular build (which does vastly simplify the build for native modules). It would be worth investigating making them use the same system (which does actually use the C preprocessor) as the regular build.