Help building for iOS Simulator on arm64 #21

tsouza-squid · 2023-04-27T16:02:41Z

tsouza-squid
Apr 27, 2023

Hi,

I am trying to build it for iOS Simulator on arm64 (M1/M2), but compilation fails. Here is what I did:

Checked out main branch
Set NODE_VERSION_IS_RELEASE 1 in src/node_version.h
Made the following changes in src/ios_framework_prepare.sh:
3.1. Commented lines 65-84 (disables compiling nodejs for x64)
3.2. Commented lines 107-110 (arm64 is already built at that point)
3.3. Changed line 115 to be -arch arm64.

Eventually I get the following error:

  g++ -o /Users/thiago/Downloads/nodejs-mobile/out/Release/obj.host/v8_base_without_compiler/deps/v8/src/heap/base/asm/arm64/push_registers_asm.o ../deps/v8/src/heap/base/asm/arm64/push_registers_asm.cc '-D_GLIBCXX_USE_CXX11_ABI=1' '-DNODE_OPENSSL_CONF_NAME=nodejs_conf' '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64' '-D_DARWIN_USE_64_BIT_INODE=1' '-DOPENSSL_NO_PINSHARED' '-DOPENSSL_THREADS' '-DOPENSSL_NO_ASM' '-DV8_TARGET_ARCH_ARM64' '-DV8_HAVE_TARGET_OS' '-DV8_TARGET_OS_IOS' '-DV8_EMBEDDER_STRING="-node.22"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DENABLE_MINOR_MC' '-DOBJECT_PRINT' '-DV8_ATOMIC_OBJECT_FIELD_WRITES' '-DV8_ATOMIC_MARKING_STATE' '-DV8_ENABLE_LAZY_SOURCE_POSITIONS' '-DV8_USE_SIPHASH' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DV8_WIN64_UNWINDING_INFO' '-DV8_ENABLE_REGEXP_INTERPRETER_THREADED_DISPATCH' '-DV8_SNAPSHOT_COMPRESSION' '-DV8_ENABLE_WEBASSEMBLY' '-DV8_ALLOCATION_FOLDING' '-DV8_ALLOCATION_SITE_TRACKING' '-DV8_ADVANCED_BIGINT_ALGORITHMS' -I../deps/v8 -I../deps/v8/include -I/Users/thiago/Downloads/nodejs-mobile/out/Release/obj/gen/inspector-generated-output-root -I../deps/v8/third_party/inspector_protocol -I/Users/thiago/Downloads/nodejs-mobile/out/Release/obj/gen -I/Users/thiago/Downloads/nodejs-mobile/out/Release/obj/gen/generate-bytecode-output-root -I../deps/v8/third_party/zlib -I../deps/v8/third_party/zlib/google  -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk -O3 -gdwarf-2 -mmacosx-version-min=10.10 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fembed-bitcode -MMD -MF /Users/thiago/Downloads/nodejs-mobile/out/Release/.deps//Users/thiago/Downloads/nodejs-mobile/out/Release/obj.host/v8_base_without_compiler/deps/v8/src/heap/base/asm/arm64/push_registers_asm.o.d.raw   -c
error: brackets expression not supported on this target
  stp x19, x20, [sp, #-16]!                        
                ^
error: brackets expression not supported on this target
  stp x21, x22, [sp, #-16]!                        
                ^
error: brackets expression not supported on this target
  stp x23, x24, [sp, #-16]!                        
                ^
error: brackets expression not supported on this target
  stp x25, x26, [sp, #-16]!                        
                ^
error: brackets expression not supported on this target
  stp x27, x28, [sp, #-16]!                        
                ^
error: brackets expression not supported on this target
  stp fp, lr,   [sp, #-16]!                        
                ^
error: unknown use of instruction mnemonic without a size suffix
  mov fp, sp                                       
  ^
error: unknown use of instruction mnemonic without a size suffix
  mov x7, x2                                       
  ^
error: unknown use of instruction mnemonic without a size suffix
  mov x2, sp                                       
  ^
error: invalid instruction mnemonic 'blr'
  blr x7                                           
  ^~~
error: brackets expression not supported on this target
  ldp fp, lr, [sp], #16                            
              ^
error: unknown token in expression
  add sp, sp, #80                                  
              ^
<inline asm>:5:17: error: brackets expression not supported on this target
  stp x19, x20, [sp, #-16]!                        
                ^
error: cannot compile inline asm
<inline asm>:6:17: error: brackets expression not supported on this target
  stp x21, x22, [sp, #-16]!                        
                ^
error: cannot compile inline asm
<inline asm>:7:17: error: brackets expression not supported on this target
  stp x23, x24, [sp, #-16]!                        
                ^
error: cannot compile inline asm
<inline asm>:8:17: error: brackets expression not supported on this target
  stp x25, x26, [sp, #-16]!                        
                ^
error: cannot compile inline asm
<inline asm>:9:17: error: brackets expression not supported on this target
  stp x27, x28, [sp, #-16]!                        
                ^
error: cannot compile inline asm
<inline asm>:10:17: error: brackets expression not supported on this target
  stp fp, lr,   [sp, #-16]!                        
                ^
error: cannot compile inline asm
<inline asm>:11:3: error: unknown use of instruction mnemonic without a size suffix
  mov fp, sp                                       
  ^
error: cannot compile inline asm
<inline asm>:12:3: error: unknown use of instruction mnemonic without a size suffix
  mov x7, x2                                       
  ^
error: cannot compile inline asm
<inline asm>:13:3: error: unknown use of instruction mnemonic without a size suffix
  mov x2, sp                                       
  ^
error: cannot compile inline asm
<inline asm>:14:3: error: invalid instruction mnemonic 'blr'
  blr x7                                           
  ^~~
error: cannot compile inline asm
<inline asm>:15:15: error: brackets expression not supported on this target
  ldp fp, lr, [sp], #16                            
              ^
error: cannot compile inline asm
<inline asm>:16:15: error: unknown token in expression
  add sp, sp, #80                                  
              ^
error: cannot compile inline asm
12 errors generated.
make[1]: *** [/Users/thiago/Downloads/nodejs-mobile/out/Release/obj.host/v8_base_without_compiler/deps/v8/src/heap/base/asm/arm64/push_registers_asm.o] Error 1
make[1]: *** Waiting for unfinished jobs....
rm 1cf7e5a2a6627d83c5f324b9b1bf24d742e77b1c.intermediate 64180b3838e897e6f8d46d58050b89f920c0b0eb.intermediate 826c26d589f170098bed51673d662e26e632e303.intermediate 1a5a7545faf3ad3dcd2d691dc5f86c062d1e91f7.intermediate
make: *** [node] Error 2

My environment:

Hardware: Apple M1 Pro 
OS: Ventura 13.3.1
xcodebuild -version
  Xcode 14.3ld -version 
  Build version 14E222b
g++ --version
  Apple clang version 14.0.3 (clang-1403.0.22.14.1)
  Target: arm64-apple-darwin22.4.0
  Thread model: posix
  InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

Any help appreciated!

Thanks!

staltz · 2023-04-28T07:12:19Z

staltz
Apr 28, 2023
Maintainer

The asm errors remind me of #10 and its fix 2522053

1 reply

tsouza Apr 28, 2023

Hi, I am not sure. I think the culprit here is that it tries to compile v8 source codes that targets arm64 (i.e. /deps/v8/src/heap/base/asm/arm64/push_registers_asm.cc) but it's setting -arch x84_64. I took a quick look into the Makefiles generate in out and several CFLAGS were with -arch x84_64 even though I've set the correct flags for arm64 before running configure.

I tried running this:

find ./out -type f -name "*.mk" -exec sed -i '' 's/-arch x86_64/-arch arm64/g' {} \;

Which got me passed that issue and the script could reach xcodebuild, but then it failed at linking stage when it tried to build with sdk iphonesimulator saying that the nodejs binaries were built for iOS instead of iOS Simulator. I am not sure how this issue did not happen with the original script that builds for x64 but still uses --dest-os=ios when building nodejs for x64

tsouza-squid · 2023-04-28T10:42:08Z

tsouza-squid
Apr 28, 2023
Author

Nevermind. I just learned I can run tests with it built for iOS Simulator x86_64 on M1/M2.

Sorry, I am quite new to this platform.

1 reply

staltz Apr 28, 2023
Maintainer

Yes, that's right. But it's also slow. I believe if we got it compiled for iOS Simulator on M1, then it would startup much faster.

tsouza-squid · 2023-04-28T10:59:32Z

tsouza-squid
Apr 28, 2023
Author

Performance shouldn't be a problem since we are building only a swift library and not an application. But I will return to this matter if/when performance becomes an issue for us. Thanks!

…

On Fri, Apr 28, 2023 at 11:55 AM André Staltz ***@***.***> wrote: Yes, that's right. But it's also slow. I believe if we got it compiled for iOS Simulator on M1, then it would startup much faster. — Reply to this email directly, view it on GitHub <#21 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A3223L3VOEYQK5Y4UHGO7ELXDOOZLANCNFSM6AAAAAAXOCID5I> . You are receiving this because you modified the open/close state.Message ID: <nodejs-mobile/nodejs-mobile/repo-discussions/21/comments/5753204@ github.com>

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Node.js Mobile

Help building for iOS Simulator on arm64 #21

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Replies: 3 comments 2 replies

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

Node.js Mobile

Help building for iOS Simulator on arm64 #21

Uh oh!

Uh oh!

tsouza-squid Apr 27, 2023

Replies: 3 comments · 2 replies

Uh oh!

staltz Apr 28, 2023 Maintainer

Uh oh!

tsouza Apr 28, 2023

Uh oh!

tsouza-squid Apr 28, 2023 Author

Uh oh!

staltz Apr 28, 2023 Maintainer

Uh oh!

tsouza-squid Apr 28, 2023 Author

tsouza-squid
Apr 27, 2023

Replies: 3 comments 2 replies

staltz
Apr 28, 2023
Maintainer

tsouza-squid
Apr 28, 2023
Author

staltz Apr 28, 2023
Maintainer

tsouza-squid
Apr 28, 2023
Author