issue: handleSubmit does not throw error when validation is invalid

[misako0927]

Version Number

7.51.0

Codesandbox/Expo snack

https://codesandbox.io/p/sandbox/handlesubmit-does-not-throw-error-when-validation-is-invalid-h5tfmj?file=%2Fsrc%2FApp.tsx

Steps to reproduce

1. Go to CodeSandbox
2. Click on submit

Expected behaviour

expect: isSuccesSubmit set to false if validation has error
actual: isSuccessSubmit set to true regardless validation result

I think it should be checked there has validation errors in below logic:

react-hook-form/src/logic/createFormControl.ts

Line 1162 in 97c3ba4

if (onValidError) {

I expected that result but it might be misunderstanding.

What browsers are you seeing the problem on?

No response

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[Moshyfawn]

Sandbox not found.

[misako0927]

@Moshyfawn I'm sorry. I changed directory. Could you see this?:
https://codesandbox.io/p/sandbox/handlesubmit-does-not-throw-error-when-validation-is-invalid-h5tfmj?file=%2Fsrc%2FApp.tsx

[Moshyfawn]

No, still "not found" 😅

[misako0927]

I changed permission. I'm sorry for inconvenience.

[Moshyfawn]

You are calling handleSubmit inside the try catch block, which shouldn't throw. It's the onValid callback inside handleSubmit that throws in case there was an error in your submit handler.

You can refer to the rules section for a try catch example.

[misako0927]

Thank you for your comment and I'm sorry for late reply.
I understand thrown error which is in handleSubmit is only used for onValid.