Improvement for select with multiple modifier

[krnlde]

Hey Bill, I just saw this code piece

react-hook-form/src/logic/getMultipleSelectValue.ts

Lines 1 to 6 in 3a4c79b

	export default (
	options: HTMLOptionElement[] | HTMLOptionsCollection,
	): string[] =>
	[...options]
	.filter(({ selected }): boolean => selected)
	.map(({ value }): string => value);

and thought this could be improved by browser native properties

https://developer.mozilla.org/en-US/docs/Web/API/HTMLSelectElement/selectedOptions

Hope this is somehow useful.

Specifically with:

Array.from(e.target.selectedOptions).map(({value}) => value)

you could skip the filter part.

Cheers mate :)

[bluebill1049]

hey @krnlde,

how are you? This is awesome! I love to save bytes, this change will be more performant and probably get us back to 8.2kb again. please send a PR, it's your contribution! ✨✌🏻 (if you are i can take over, and mention your name in the realse note)

Cheers
Bill

[krnlde]

I'm really fine thank you for asking :) Still using this library on a daily basis. How are you? How do you keep the issue count at around zero still :D that's still unbelievable. Keep it up!

[bluebill1049]

hahaha thanks 🙏 that's awesome to hear, great power comes with great responsibility. I am just doing my part, so everyone in the community can enjoy working with forms a bit more.

[krnlde]

It's not working in IE though. Is that a problem?

[bluebill1049]

nope, we have stopped stop IE11 from v7.

[bluebill1049]

looks great.

[krnlde]

X-Ref: #6678