Potential dead code

[NMinhNguyen]

Was just going through the code and spotted a couple of things:

• What’s the point in Object.keys(_formState.errors).every() when there’s a check for _formState.errors being empty?

  react-hook-form/src/logic/createFormControl.ts

  Lines 1041 to 1042 in 248c7c7

  	isEmptyObject(_formState.errors) &&
  	Object.keys(_formState.errors).every((name) => get(fieldValues, name))

• This module seems to be unused: https://github.com/react-hook-form/react-hook-form/blob/248c7c7187accf2fa040d0f4287ff4915cf66386/src/logic/setCustomValidty.ts

[bluebill1049]

good find! please send PR 👍

[NMinhNguyen]

Thanks! You definitely didn’t mean || instead of && for example?

[bluebill1049]

pass test without the .every check 🌷