Build Failure After Code Sync Requesting Guidance

[zeslabconnect1]

Hi ,

I’ve synced the latest code and attempted to compile using the following commands to use GPU :

meson setup builddir_full -Dexamples=false -Dtests=false -Dcpp_std=c++17 --reconfigure
ninja -C builddir_full

However, the build failed. Could you please advise if i should use some other branch from main ?

[1/278] Compiling C++ object src/thorvg-1.dll.p/renderer_gl_engine_tvgGlRenderPass.cpp.obj FAILED: [code=2] src/thorvg-1.dll.p/renderer_gl_engine_tvgGlRenderPass.cpp.obj "cl" "-Isrc\thorvg-1.dll.p" "-Isrc" "-I..\src" "-Iinc" "-I..\inc" "-I." "-I.." "-Isrc\loaders\lottie" "-I..\src\loaders\lottie" "-Isrc\renderer" "-I..\src\renderer" "-Isrc\renderer\gl_engine" "-I..\src\renderer\gl_engine" "-Isrc\common" "-I..\src\common" "-Isrc\loaders" "-I..\src\loaders" "-Isrc\loaders\svg" "-I..\src\loaders\svg" "-Isrc\loaders\ttf" "-I..\src\loaders\ttf" "-Isrc\loaders\lottie\jerryscript\jerry-core\api" "-I..\src\loaders\lottie\jerryscript\jerry-core\api" "-Isrc\loaders\lottie\jerryscript\jerry-core\include" "-I..\src\loaders\lottie\jerryscript\jerry-core\include" "-Isrc\loaders\lottie\jerryscript\jerry-core\ecma\base" "-I..\src\loaders\lottie\jerryscript\jerry-core\ecma\base" "-Isrc\loaders\lottie\jerryscript\jerry-core\ecma\builtin-objects\typedarray" "-I..\src\loaders\lottie\jerryscript\jerry-core\ecma\builtin-objects\typedarray" "-Isrc\loaders\lottie\jerryscript\jerry-core\ecma\builtin-objects" "-I..\src\loaders\lottie\jerryscript\jerry-core\ecma\builtin-objects" "-Isrc\loaders\lottie\jerryscript\jerry-core\ecma\operations" "-I..\src\loaders\lottie\jerryscript\jerry-core\ecma\operations" "-Isrc\loaders\lottie\jerryscript\jerry-core\jcontext" "-I..\src\loaders\lottie\jerryscript\jerry-core\jcontext" "-Isrc\loaders\lottie\jerryscript\jerry-core\jmem" "-I..\src\loaders\lottie\jerryscript\jerry-core\jmem" "-Isrc\loaders\lottie\jerryscript\jerry-core\jrt" "-I..\src\loaders\lottie\jerryscript\jerry-core\jrt" "-Isrc\loaders\lottie\jerryscript\jerry-core\lit" "-I..\src\loaders\lottie\jerryscript\jerry-core\lit" "-Isrc\loaders\lottie\jerryscript\jerry-core\parser\js" "-I..\src\loaders\lottie\jerryscript\jerry-core\parser\js" "-Isrc\loaders\lottie\jerryscript\jerry-core\parser\regexp" "-I..\src\loaders\lottie\jerryscript\jerry-core\parser\regexp" "-Isrc\loaders\lottie\jerryscript\jerry-core\vm" "-I..\src\loaders\lottie\jerryscript\jerry-core\vm" "-Isrc\loaders\png" "-I..\src\loaders\png" "-Isrc\loaders\jpg" "-I..\src\loaders\jpg" "-Isrc\loaders\webp" "-I..\src\loaders\webp" "-Isrc\loaders\webp\dec" "-I..\src\loaders\webp\dec" "-Isrc\loaders\webp\dsp" "-I..\src\loaders\webp\dsp" "-Isrc\loaders\webp\utils" "-I..\src\loaders\webp\utils" "-Isrc\loaders\webp\webp" "-I..\src\loaders\webp\webp" "-Isrc\loaders\raw" "-I..\src\loaders\raw" "-Isrc\savers" "-I..\src\savers" "-Isrc\savers\gif" "-I..\src\savers\gif" "/MD" "/nologo" "/showIncludes" "/utf-8" "/Zc:__cplusplus" "/W2" "/EHsc" "/std:c++17" "/permissive-" "/O2" "/Gw" "/Zi" "-DEXAMPLE_DIR=\"C:/code/thorvg/examples/resources\"" "-DTEST_DIR=\"C:/code/thorvg/test/resources\"" "-DTHORVG_GL_TARGET_GL=1" "-DTVG_EXPORT" "-DTVG_BUILD" "/Fdsrc\thorvg-1.dll.p\renderer_gl_engine_tvgGlRenderPass.cpp.pdb" /Fosrc/thorvg-1.dll.p/renderer_gl_engine_tvgGlRenderPass.cpp.obj "/c" ../src/renderer/gl_engine/tvgGlRenderPass.cpp c:\code\thorvg\src\common\tvgMath.h(220): error C2059: syntax error: 'const' c:\code\thorvg\src\common\tvgMath.h(220): error C2059: syntax error: ')' c:\code\thorvg\src\common\tvgMath.h(221): error C2143: syntax error: missing ';' before '{' c:\code\thorvg\src\common\tvgMath.h(221): error C2447: '{': missing function header (old-style formal list?) c:\code\thorvg\src\common\tvgMath.h(226): error C2059: syntax error: 'const' c:\code\thorvg\src\common\tvgMath.h(226): error C2059: syntax error: ')' c:\code\thorvg\src\common\tvgMath.h(227): error C2143: syntax error: missing ';' before '{' c:\code\thorvg\src\common\tvgMath.h(227): error C2447: '{': missing function header (old-style formal list?) c:\code\thorvg\src\renderer\tvgRender.h(105): error C2589: '(': illegal token on right side of '::' c:\code\thorvg\src\renderer\tvgRender.h(105): error C3329: syntax error: expected '}' not ')' c:\code\thorvg\src\renderer\tvgRender.h(105): error C2589: '(': illegal token on right side of '::' c:\code\thorvg\src\renderer\tvgRender.h(105): error C3329: syntax error: expected '}' not ')' c:\code\thorvg\src\renderer\tvgRender.h(105): error C2143: syntax error: missing ';' before '}' c:\code\thorvg\src\renderer\tvgRender.h(103): error C3615: constexpr function 'tvg::RenderRegion::intersect' cannot result in a constant expression c:\code\thorvg\src\renderer\tvgRender.h(103): note: failure was caused by control reaching the end of a constexpr function c:\code\thorvg\src\renderer\tvgRender.h(105): error C2059: syntax error: ',' c:\code\thorvg\src\renderer\tvgRender.h(105): error C2143: syntax error: missing ';' before '{' c:\code\thorvg\src\renderer\tvgRender.h(105): error C2447: '{': missing function header (old-style formal list?) c:\code\thorvg\src\renderer\tvgRender.h(105): error C2059: syntax error: '}' c:\code\thorvg\src\renderer\tvgRender.h(107): error C2059: syntax error: 'if' c:\code\thorvg\src\renderer\tvgRender.h(108): error C2059: syntax error: 'if' c:\code\thorvg\src\renderer\tvgRender.h(109): error C2059: syntax error: 'return' c:\code\thorvg\src\renderer\tvgRender.h(110): error C2059: syntax error: '}' c:\code\thorvg\src\renderer\tvgRender.h(110): error C2143: syntax error: missing ';' before '}' c:\code\thorvg\src\renderer\tvgRender.h(114): error C2589: '(': illegal token on right side of '::' c:\code\thorvg\src\renderer\tvgRender.h(114): error C3329: syntax error: expected '}' not ')' c:\code\thorvg\src\renderer\tvgRender.h(114): error C2589: '(': illegal token on right side of '::' c:\code\thorvg\src\renderer\tvgRender.h(114): error C3329: syntax error: expected '}' not ')' c:\code\thorvg\src\renderer\tvgRender.h(114): error C2143: syntax error: missing ';' before '}' c:\code\thorvg\src\renderer\tvgRender.h(114): error C2059: syntax error: ',' c:\code\thorvg\src\renderer\tvgRender.h(114): error C2143: syntax error: missing ';' before '{' c:\code\thorvg\src\renderer\tvgRender.h(114): error C2447: '{': missing function header (old-style formal list?) c:\code\thorvg\src\renderer\tvgRender.h(114): error C2059: syntax error: '}' c:\code\thorvg\src\renderer\tvgRender.h(115): error C2059: syntax error: '}' c:\code\thorvg\src\renderer\tvgRender.h(115): error C2143: syntax error: missing ';' before '}' c:\code\thorvg\src\renderer\tvgRender.h(439): error C2589: '(': illegal token on right side of '::' c:\code\thorvg\src\renderer\tvgRender.h(439): error C2059: syntax error: ')' c:\code\thorvg\src\renderer\tvgRender.h(440): error C2589: '(': illegal token on right side of '::' c:\code\thorvg\src\renderer\tvgRender.h(440): error C2059: syntax error: ')' c:\code\thorvg\src\renderer\tvgRender.h(441): error C2589: '(': illegal token on right side of '::' c:\code\thorvg\src\renderer\tvgRender.h(441): error C2059: syntax error: ')' c:\code\thorvg\src\renderer\tvgRender.h(442): error C2589: '(': illegal token on right side of '::' c:\code\thorvg\src\renderer\tvgRender.h(442): error C2059: syntax error: ')' c:\code\thorvg\src\renderer\tvgRender.h(465): error C2589: '(': illegal token on right side of '::' c:\code\thorvg\src\renderer\tvgRender.h(465): error C2059: syntax error: ')' c:\code\thorvg\src\renderer\tvgRender.h(466): error C2589: '(': illegal token on right side of '::' c:\code\thorvg\src\renderer\tvgRender.h(466): error C2059: syntax error: ')' [2/278] Compiling C++ object src/thorvg-1.dll.p/renderer_gl_engine_tvgGlProgram.cpp.obj FAILED: [code=2] src/thorvg-1.dll.p/renderer_gl_engine_tvgGlProgram.cpp.obj "cl" "-Isrc\thorvg-1.dll.p" "-Isrc" "-I..\src" "-Iinc" "-I..\inc" "-I." "-I.." "-Isrc\loaders\lottie" "-I..\src\loaders\lottie" "-Isrc\renderer" "-I..\src\renderer" "-Isrc\renderer\gl_engine" "-I..\src\renderer\gl_engine" "-Isrc\common" "-I..\src\common" "-Isrc\loaders" "-I..\src\loaders" "-Isrc\loaders\svg" "-I..\src\loaders\svg" "-Isrc\loaders\ttf" "-I..\src\loaders\ttf" "-Isrc\loaders\lottie\jerryscript\jerry-core\api" "-I..\src\loaders\lottie\jerryscript\jerry-core\api" "-Isrc\loaders\lottie\jerryscript\jerry-core\include" "-I..\src\loaders\lottie\jerryscript\jerry-core\include" "-Isrc\loaders\lottie\jerryscript\jerry-core\ecma\base" "-I..\src\loaders\lottie\jerryscript\jerry-core\ecma\base" "-Isrc\loaders\lottie\jerryscript\jerry-core\ecma\builtin-objects\typedarray" "-I..\src\loaders\lottie\jerryscript\jerry-core\ecma\builtin-objects\typedarray" "-Isrc\loaders\lottie\jerryscript\jerry-core\ecma\builtin-objects" "-I..\src\loaders\lottie\jerryscript\jerry-core\ecma\builtin-objects" "-Isrc\loaders\lottie\jerryscript\jerry-core\ecma\operations" "-I..\src\loaders\lottie\jerryscript\jerry-core\ecma\operations" "-Isrc\loaders\lottie\jerryscript\jerry-core\jcontext" "-I..\src\loaders\lottie\jerryscript\jerry-core\jcontext" "-Isrc\loaders\lottie\jerryscript\jerry-core\jmem" "-I..\src\loaders\lottie\jerryscript\jerry-core\jmem" "-Isrc\loaders\lottie\jerryscript\jerry-core\jrt" "-I..\src\loaders\lottie\jerryscript\jerry-core\jrt" "-Isrc\loaders\lottie\jerryscript\jerry-core\lit" "-I..\src\loaders\lottie\jerryscript\jerry-core\lit" "-Isrc\loaders\lottie\jerryscript\jerry-core\parser\js" "-I..\src\loaders\lottie\jerryscript\jerry-core\parser\js" "-Isrc\loaders\lottie\jerryscript\jerry-core\parser\regexp" "-I..\src\loaders\lottie\jerryscript\jerry-core\parser\regexp" "-Isrc\loaders\lottie\jerryscript\jerry-core\vm" "-I..\src\loaders\lottie\jerryscript\jerry-core\vm" "-Isrc\loaders\png" "-I..\src\loaders\png" "-Isrc\loaders\jpg" "-I..\src\loaders\jpg" "-Isrc\loaders\webp" "-I..\src\loaders\webp" "-Isrc\loaders\webp\dec" "-I..\src\loaders\webp\dec" "-Isrc\loaders\webp\dsp" "-I..\src\loaders\webp\dsp" "-Isrc\loaders\webp\utils" "-I..\src\loaders\webp\utils" "-Isrc\loaders\webp\webp" "-I..\src\loaders\webp\webp" "-Isrc\loaders\raw" "-I..\src\loaders\raw" "-Isrc\savers" "-I..\src\savers" "-Isrc\savers\gif" "-I..\src\savers\gif" "/MD" "/nologo" "/showIncludes" "/utf-8" "/Zc:__cplusplus" "/W2" "/EHsc" "/std:c++17" "/permissive-" "/O2" "/Gw" "/Zi" "-DEXAMPLE_DIR=\"C:/code/thorvg/examples/resources\"" "-DTEST_DIR=\"C:/code/thorvg/test/resources\"" "-DTHORVG_GL_TARGET_GL=1" "-DTVG_EXPORT" "-DTVG_BUILD" "/Fdsrc\thorvg-1.dll.p\renderer_gl_engine_tvgGlProgram.cpp.pdb" /Fosrc/thorvg-1.dll.p/renderer_gl_engine_tvgGlProgram.cpp.obj "/c" ../src/renderer/gl_engine/tvgGlProgram.cpp

[hermet]

@zeslabconnect1 Hello, please remove the build folder builddir_full and try again with this?

$meson setup builddir_full -Dloaders=all

[zeslabconnect1]

The command created non GPU but I need GPU support

thorvg 1.0.0

Build Type        : debugoptimized
Prefix            : c:/
File I/O          : YES
Multi-Tasking     : YES
Partial Rendering : YES
SIMD Instruction  : none
Log Message       : NO
Tests             : NO
Examples          : NO

Raster Engine
SW : YES
GL : NO <===========this is not yet YES
WG : NO

The problem comes Only when I enable GPU 

[hermet]

@zeslabconnect1 $meson setup builddir_full -Dloaders=all -Dengines="sw, gl"

[zeslabconnect1]

[41/280] Compiling C++ object src/thorvg-1.dll.p/renderer_gl_engine_tvgGlShader.cpp.obj
FAILED: [code=2] src/thorvg-1.dll.p/renderer_gl_engine_tvgGlShader.cpp.obj
"cl" "-Isrc\thorvg-1.dll.p" "-Isrc" "-I..\src" "-Iinc" "-I..\inc" "-I." "-I.." "-Isrc\loaders\lottie" "-I..\src\loaders\lottie" "-Isrc\renderer" "-I..\src\renderer" "-Isrc\renderer\sw_engine" "-I..\src\renderer\sw_engine" "-Isrc\renderer\gl_engine" "-I..\src\renderer\gl_engine" "-Isrc\common" "-I..\src\common" "-Isrc\loaders" "-I..\src\loaders" "-Isrc\loaders\svg" "-I..\

I'm still getting the same error. I'm running the above commands
meson setup builddir_full -Dloaders=all -Dengines="sw, gl"
from within the Visual Studio 2022 command prompt. Do I need to install any additional compilers or tools to get it working?

[zeslabconnect1]

@hermet can you please share your build infrastructure details like compiler version , c++ version etc so that I can try to replicate and resolve this issue

[hermet]

@SergeyLebedkin Could you please help this?

[hermet]

@zeslabconnect1 I don't use VS. how about trying this? meson setup builddir_full -Dloaders=all -Dengines="sw, gl" -Dbackend=vs

[zeslabconnect1]

@hermet The command generates a .vcxproj and a .sln file. However, I’m looking to build the project using Meson for a few other reasons. Could you please share the details of your setup? I'd like to align my Windows environment with official one to ensure things start compiling properly for GPU

When I run the command you shared , I get the .vcxproj and .sln files, but encounter a compilation error on building .
4>tvgCompressor.cpp 4>tvgGlProgram.cpp 4>thorvg\src\common\tvgMath.h(220,21): error C2059: syntax error: 'const' 4>(compiling source file '../../src/renderer/gl_engine/tvgGlRenderPass.cpp') 4>thorvg\src\common\tvgMath.h(220,21): error C2059: syntax error: ')'
...

[SergeyLebedkin]

@zeslabconnect1 Please, try to add NOMINMAX define into project settigs

[zeslabconnect1]

@SergeyLebedkin thanks this compiles it . Can you get it added in meson please as that way i could use meson with no changes as that is a prefered system

Is this a bug or if there is a workaround from meson ?

[SergeyLebedkin]

Yes... we will add this permanently to the meson script

[SergeyLebedkin]

#3799

[zeslabconnect1]

@SergeyLebedkin @hermet
after this step i am seeing strange error inlinking the created dll
The entre setup which was woking for Sw has stopped working now

Since both GPU and CPU code exist will this line not work ? and will i have to write some other code for canvas

mCanvas = std::unique_ptrtvg::SwCanvas(tvg::SwCanvas::gen());

Error:
15>Ui2.lib(UILottieButtonView.obj) : error LNK2019: unresolved external symbol "__declspec(dllimport) public: static class tvg::SwCanvas * __cdecl tvg::SwCanvas::gen(void)" (__imp_?gen@SwCanvas@tvg@@SAPEAV12@XZ) referenced in function "private: void __cdecl UI::UILottieButtonView::DrawLottieFrame(class UIBaseCanvas *,struct UIRect const &,unsigned int)" (?DrawLottieFrame@UILottieButtonView@UI@@AEAAXPEAVUIBaseCanvas@@AEBUAVRect@@I@Z)

[SergeyLebedkin]

Please, try to add reference to your project to the thorvg-1.dll proj