You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the nav-link and nav-pills items sit at 36px in height. This is due to having no border around them.
By contrast, nav-tabs, and nav-underline, have a height of 38px (2.25rem), this is because nav-tabs have a 1px border around them, while nav-underline have 2px underneath each element.
My proposed change is to increase the height of nav-link and nav-pills to 38px, by adding an invisible border to match the height of nav-tabs and nav-underline counterparts.
Additionally, it's super common to use an in-page nav alongside a search input component, or an additional button component (that's outside the scope of the nav itself), for example:
Before
After
This will make all nav variants (link, pill, tab, underline) cohesive, having the same height across the board, regardless of each version is used.
I've done a PR with the change for you guys to have a look at: #42146
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Currently, the
nav-linkandnav-pillsitems sit at36pxin height. This is due to having no border around them.By contrast,
nav-tabs, andnav-underline, have a height of38px(2.25rem), this is becausenav-tabshave a1pxborder around them, whilenav-underlinehave 2px underneath each element.My proposed change is to increase the height of
nav-linkandnav-pillsto 38px, by adding an invisible border to match the height ofnav-tabsandnav-underlinecounterparts.Additionally, it's super common to use an in-page
navalongside a searchinputcomponent, or an additionalbuttoncomponent (that's outside the scope of the nav itself), for example:Before
After
This will make all
navvariants (link,pill,tab,underline) cohesive, having the same height across the board, regardless of each version is used.I've done a PR with the change for you guys to have a look at: #42146
Beta Was this translation helpful? Give feedback.
All reactions