Duplicated export presence logic across Harmony dependency classes #20528
Closed
kartikeyg0104
started this conversation in
Ideas
Replies: 1 comment
-
|
AI generated issues will be closed |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Summary
HarmonyImportSpecifierDependencyandHarmonyExportImportedSpecifierDependencycontain near-identical implementations of_getEffectiveExportPresenceLevel(),getWarnings(), andgetErrors(). The sameexportPresenceModeresolution logic is also duplicated acrossHarmonyImportDependencyParserPlugin,HarmonyExportDependencyParserPlugin, andImportParserPlugin. A utility functiongetNonOptionalPart()is copied verbatim in two parser plugins.Impact
Beta Was this translation helpful? Give feedback.
All reactions