Add confirmation prompt for new stack creation

- Add user confirmation prompt to deployNewStack for consistency with existing stack updates
- Show stack details (name, parameter count, tag count) before prompting
- Allow users to cancel stack creation before AWS resources are created
- Update deployment tests to mock confirmation prompt and prevent hanging
- Fix variable redeclaration error in deployment callback
- Maintain consistent and safer user experience across all deployment scenarios

Author: orien

internal/deploy/deployer.go

@@ -67,6 +67,27 @@ func (d *AWSDeployer) DeployStack(ctx context.Context, stack *model.Stack) error
 func (d *AWSDeployer) deployNewStack(ctx context.Context, stack *model.Stack) error {
 	fmt.Printf("=== Creating new stack %s ===\n", stack.Name)
 
+	// Show what will be created
+	fmt.Printf("This will create a new CloudFormation stack with:\n")
+	fmt.Printf("- Name: %s\n", stack.Name)
+	if len(stack.Parameters) > 0 {
+		fmt.Printf("- Parameters: %d\n", len(stack.Parameters))
+	}
+	if len(stack.Tags) > 0 {
+		fmt.Printf("- Tags: %d\n", len(stack.Tags))
+	}
+	fmt.Println()
+
+	// Prompt for confirmation before creating new resources
+	confirmed, err := prompt.ConfirmDeployment(stack.Name)
+	if err != nil {
+		return fmt.Errorf("failed to get user confirmation: %w", err)
+	}
+	if !confirmed {
+		fmt.Printf("Stack creation cancelled for %s\n", stack.Name)
+		return nil
+	}
+
 	// Convert parameters to AWS format
 	awsParams := make([]aws.Parameter, 0, len(stack.Parameters))
 	for key, value := range stack.Parameters {
@@ -106,7 +127,7 @@ func (d *AWSDeployer) deployNewStack(ctx context.Context, stack *model.Stack) er
 	cfnOps := d.awsClient.NewCloudFormationOperations()
 
 	// Deploy the stack with event streaming
-	err := cfnOps.DeployStackWithCallback(ctx, deployInput, eventCallback)
+	err = cfnOps.DeployStackWithCallback(ctx, deployInput, eventCallback)
 	if err != nil {
 		return fmt.Errorf("failed to create stack: %w", err)
 	}

internal/deploy/deployer_test.go

@@ -158,6 +158,15 @@ func TestAWSDeployer_DeployStack_Success(t *testing.T) {
 	// Test successful stack deployment
 	ctx := context.Background()
 
+	// Set up mock prompter for confirmation
+	mockPrompter := &MockPrompter{}
+	originalPrompter := prompt.GetDefaultPrompter()
+	prompt.SetPrompter(mockPrompter)
+	defer prompt.SetPrompter(originalPrompter)
+
+	// Mock user confirmation (new stack creation requires confirmation)
+	mockPrompter.On("ConfirmDeployment", "test-stack").Return(true, nil)
+
 	// Create temporary template file
 	tmpDir := t.TempDir()
 	templateFile := filepath.Join(tmpDir, "test-template.json")
@@ -215,9 +224,18 @@ func TestAWSDeployer_DeployStack_Success(t *testing.T) {
 	assert.NoError(t, err)
 	mockClient.AssertExpectations(t)
 	mockCfnOps.AssertExpectations(t)
+	mockPrompter.AssertExpectations(t)
 }
 
 func TestAWSDeployer_DeployStack_WithEmptyTemplate(t *testing.T) {
+	// Set up mock prompter for confirmation
+	mockPrompter := &MockPrompter{}
+	originalPrompter := prompt.GetDefaultPrompter()
+	prompt.SetPrompter(mockPrompter)
+	defer prompt.SetPrompter(originalPrompter)
+
+	// Mock user confirmation (new stack creation requires confirmation)
+	mockPrompter.On("ConfirmDeployment", "test-stack").Return(true, nil)
 	// Test deploy stack with empty template body
 	ctx := context.Background()
 
@@ -253,9 +271,18 @@ func TestAWSDeployer_DeployStack_WithEmptyTemplate(t *testing.T) {
 	assert.NoError(t, err)
 	mockClient.AssertExpectations(t)
 	mockCfnOps.AssertExpectations(t)
+	mockPrompter.AssertExpectations(t)
 }
 
 func TestAWSDeployer_DeployStack_AWSError(t *testing.T) {
+	// Set up mock prompter for confirmation
+	mockPrompter := &MockPrompter{}
+	originalPrompter := prompt.GetDefaultPrompter()
+	prompt.SetPrompter(mockPrompter)
+	defer prompt.SetPrompter(originalPrompter)
+
+	// Mock user confirmation (new stack creation requires confirmation)
+	mockPrompter.On("ConfirmDeployment", "test-stack").Return(true, nil)
 	// Test deploy stack when AWS returns an error
 	ctx := context.Background()
 
@@ -303,6 +330,7 @@ func TestAWSDeployer_DeployStack_AWSError(t *testing.T) {
 
 	mockClient.AssertExpectations(t)
 	mockCfnOps.AssertExpectations(t)
+	mockPrompter.AssertExpectations(t)
 }
 
 func TestAWSDeployer_DeployStack_NoChanges(t *testing.T) {
@@ -349,7 +377,7 @@ func TestAWSDeployer_DeployStack_NoChanges(t *testing.T) {
 	// Execute
 	err := deployer.DeployStack(ctx, stack)
 
-	// Verify - should succeed with no error despite NoChangesError
+	// Verify - should succeed with no error when no changes detected
 	assert.NoError(t, err)
 	mockClient.AssertExpectations(t)
 	mockCfnOps.AssertExpectations(t)
@@ -528,6 +556,14 @@ func TestAWSDeployer_ValidateTemplate_ValidationError(t *testing.T) {
 }
 
 func TestAWSDeployer_DeployStack_WithYAMLTemplate(t *testing.T) {
+	// Set up mock prompter for confirmation
+	mockPrompter := &MockPrompter{}
+	originalPrompter := prompt.GetDefaultPrompter()
+	prompt.SetPrompter(mockPrompter)
+	defer prompt.SetPrompter(originalPrompter)
+
+	// Mock user confirmation (new stack creation requires confirmation)
+	mockPrompter.On("ConfirmDeployment", "test-stack").Return(true, nil)
 	// Test deploying stack with YAML template content
 	ctx := context.Background()
 
@@ -573,12 +609,22 @@ Resources:
 	assert.NoError(t, err)
 	mockClient.AssertExpectations(t)
 	mockCfnOps.AssertExpectations(t)
+	mockPrompter.AssertExpectations(t)
 }
 
 func TestAWSDeployer_DeployStack_WithMultipleParametersAndTags(t *testing.T) {
-	// Test deploying stack with multiple parameters and tags
+	// Test deployment with multiple parameters and tags
 	ctx := context.Background()
 
+	// Set up mock prompter for confirmation
+	mockPrompter := &MockPrompter{}
+	originalPrompter := prompt.GetDefaultPrompter()
+	prompt.SetPrompter(mockPrompter)
+	defer prompt.SetPrompter(originalPrompter)
+
+	// Mock user confirmation (new stack creation requires confirmation)
+	mockPrompter.On("ConfirmDeployment", "test-stack").Return(true, nil)
+
 	// Set up mocks
 	mockCfnOps := &MockCloudFormationOperations{}
 	mockClient := &MockAWSClient{}
@@ -616,4 +662,5 @@ func TestAWSDeployer_DeployStack_WithMultipleParametersAndTags(t *testing.T) {
 	assert.NoError(t, err)
 	mockClient.AssertExpectations(t)
 	mockCfnOps.AssertExpectations(t)
+	mockPrompter.AssertExpectations(t)
 }