Use Implementation-Version as raw version (getsentry#4291)

* Check for mixed SDK versions

* Format code

* format + api

* Init noops if mixed versions detected

* Add BuildConfig

* config entries for agentless module sdk names

* Add MANIFEST.MF for JARs

* Throw on startup; use manifests for backend; reuse code for otel

* Format code

* Format code

* changelog

* api

* changelog

* Remove duplicate addPackage calls

* remove test assertion for package

* Introduce fatal SDK logger

* Use Implementation-Version as raw version

* Format code

* changelog

* remove duplicate attr def

---------

Co-authored-by: Sentry Github Bot <[email protected]>

Author: adinauer

CHANGELOG.md

@@ -24,6 +24,9 @@
 
 - Do not override user-defined `SentryOptions` ([#4262](https://github.com/getsentry/sentry-java/pull/4262))
 - Session Replay: Change bitmap config to `ARGB_8888` for screenshots ([#4282](https://github.com/getsentry/sentry-java/pull/4282))
+- The `MANIFEST.MF` of `sentry-opentelemetry-agent` now has `Implementation-Version` set to the raw version ([#4291](https://github.com/getsentry/sentry-java/pull/4291))
+  - An example value would be `8.6.0`
+  - The value of the `Sentry-Version-Name` attribute looks like `sentry-8.5.0-otel-2.10.0`
 
 ### Internal
 

sentry-opentelemetry/sentry-opentelemetry-agent/build.gradle.kts

@@ -147,8 +147,8 @@ tasks {
             attributes.put("Can-Retransform-Classes", "true")
             attributes.put("Implementation-Vendor", "Sentry")
             attributes.put("Implementation-Title", project.name)
-            attributes.put("Implementation-Version", "sentry-${project.version}-otel-${Config.Libs.OpenTelemetry.otelInstrumentationVersion}")
-            attributes.put("Sentry-Version-Name", project.version)
+            attributes.put("Implementation-Version", project.version)
+            attributes.put("Sentry-Version-Name", "sentry-${project.version}-otel-${Config.Libs.OpenTelemetry.otelInstrumentationVersion}")
             attributes.put("Sentry-SDK-Name", Config.Sentry.SENTRY_OPENTELEMETRY_AGENT_SDK_NAME)
             attributes.put("Sentry-SDK-Package-Name", "maven:io.sentry:sentry-opentelemetry-agent")
             attributes.put("Sentry-Opentelemetry-SDK-Name", Config.Sentry.SENTRY_OPENTELEMETRY_AGENT_SDK_NAME)

sentry/src/main/java/io/sentry/internal/ManifestVersionReader.java

@@ -61,7 +61,7 @@ public void readManifestFiles() {
           final @Nullable Attributes mainAttributes = manifest.getMainAttributes();
           if (mainAttributes != null) {
             final @Nullable String name = mainAttributes.getValue("Sentry-Opentelemetry-SDK-Name");
-            final @Nullable String version = mainAttributes.getValue("Sentry-Version-Name");
+            final @Nullable String version = mainAttributes.getValue("Implementation-Version");
             final @Nullable String sdkName = mainAttributes.getValue("Sentry-SDK-Name");
             final @Nullable String packageName = mainAttributes.getValue("Sentry-SDK-Package-Name");