Merge pull request #2 from origranot/feat/lint

feat: add helm lint option to support sub charts

Author: origranot

cmd/common.go

@@ -21,7 +21,12 @@ func createDependencyCommand(name, desc string) *cobra.Command {
 				cmd.PrintErrln(err)
 				return
 			}
-			err = helmutil.ManageDependencies(absPath, helmutil.Command(name))
+			if name == "lint" {
+				err = helmutil.LintCharts(absPath)
+			} else {
+				err = helmutil.ManageDependencies(absPath, helmutil.DependencyCommand(name))
+			}
+
 			if err != nil {
 				cmd.PrintErrln(err)
 			}

cmd/lint.go

@@ -0,0 +1,7 @@
+package cmd
+
+var lintCmd = createDependencyCommand("lint", "Lint chart including his subcharts with correct values scope (this must be run from the root of the chart)")
+
+func init() {
+	rootCmd.AddCommand(lintCmd)
+}

pkg/dependencies.go

@@ -12,14 +12,14 @@ import (
 	"github.com/fatih/color"
 )
 
-type Command string
+type DependencyCommand string
 
 const (
-	Build  Command = "build"
-	Update Command = "update"
+	Build  DependencyCommand = "build"
+	Update DependencyCommand = "update"
 )
 
-func ManageDependencies(rootDir string, cmd Command) error {
+func ManageDependencies(rootDir string, cmd DependencyCommand) error {
 	var charts []ChartInfo
 	err := collectCharts(rootDir, &charts)
 	if err != nil {
@@ -42,20 +42,40 @@ func ManageDependencies(rootDir string, cmd Command) error {
 			fmt.Printf("%s\n", color.YellowString(stderr.String()))
 		}
 
-		var successMsg string
-		if cmd == Build {
-			successMsg = "Successfully built"
-		} else {
-			successMsg = "Successfully updated"
+		successMsg := fmt.Sprintf("dependencies %sd successfully", cmd)
+		fmt.Printf("%s %s\n", color.BlueString(chart.Name), successMsg)
+	}
+	return nil
+}
+
+func LintCharts(rootDir string) error {
+	var charts []ChartInfo
+	err := collectCharts(rootDir, &charts)
+	if err != nil {
+		return err
+	}
+
+	for i := len(charts) - 1; i >= 0; i-- {
+		chart := charts[i]
+		helmCmd := exec.Command("helm", "lint", chart.Path, "--values", path.Join(rootDir, "values.yaml"))
+
+		var stdout, stderr bytes.Buffer
+		helmCmd.Stdout = &stdout
+		helmCmd.Stderr = &stderr
+
+		if err := helmCmd.Run(); err != nil {
+			return fmt.Errorf("failed to lint chart %s:\n%s", chart.Path, color.RedString(stderr.String()))
+		}
+		if stderr.String() != "" {
+			fmt.Printf("%s\n", color.YellowString(stderr.String()))
 		}
 
-		fmt.Printf("%s %s\n", color.BlueString(chart.Name), successMsg)
+		fmt.Printf("%s linted successfully\n", color.BlueString(chart.Name))
 	}
 	return nil
 }
 
 func collectCharts(rootDir string, charts *[]ChartInfo) error {
-
 	_, err := os.Stat(path.Join(rootDir, "Chart.yaml"))
 	if err != nil {
 		return fmt.Errorf("chart not found: %s", rootDir)

plugin.yaml

@@ -1,5 +1,5 @@
 name: "cascade"
-version: "0.0.3"
+version: "1.0.0"
 usage: "Recursively manages Helm chart dependencies across all subcharts"
 description: "Recursively manages Helm chart dependencies across all subcharts"
 ignoreFlags: false