Skip to content

Commit 18427d8

Browse files
committed
CommandsDebugCommand: column with the checkmark emoji is correctly aligned (was bugged with symfony/console 7.3.1+, 7.2.8+, 6.4.23+)
1 parent 2b84a96 commit 18427d8

File tree

4 files changed

+15
-11
lines changed

4 files changed

+15
-11
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
77

88
## [Unreleased](https://github.com/orisai/nette-console/compare/1.4.5...v1.x)
99

10+
### Fixed
11+
12+
- `CommandsDebugCommand` - column with the checkmark emoji is correctly aligned (was bugged with symfony/console 7.3.1+, 7.2.8+, 6.4.23+)
13+
1014
## [1.4.5](https://github.com/orisai/nette-console/compare/1.4.4...1.4.5) - 2025-01-17
1115

1216
### Added

src/Command/CommandsDebugCommand.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ protected function execute(InputInterface $input, OutputInterface $output): int
5050
$table->addRow(['Name', 'Description', 'Service name', 'Service type']);
5151
foreach ($this->commands as [$service, $type, $name, $description]) {
5252
$table->addRow([
53-
$name ? '<fg=green>✔</>' : '<fg=red>❌</>',
54-
$description ? '<fg=green>✔</>' : '<fg=red>❌</>',
53+
$name ? '<fg=green>✔</>' : '<fg=red>❌</>',
54+
$description ? '<fg=green>✔</>' : '<fg=red>❌</>',
5555
$service,
5656
$type,
5757
]);

tests/Unit/Command/CommandsDebugCommandTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,9 @@ public function testCommands(): void
5555
Following commands are missing ❌ either name or description. Check orisai/nette-console documentation about lazy loading to learn how to fix it.
5656
5757
Name Description Service name Service type
58-
❌ service1 Tests\OriNette\Console\Doubles\UrlPrintingCommand
59-
❌ ✔ service2 Tests\OriNette\Console\Doubles\HiddenAndAliasedCommand
60-
✔️ service3 Tests\OriNette\Console\Doubles\SimpleCommand
58+
❌ service1 Tests\OriNette\Console\Doubles\UrlPrintingCommand
59+
❌ ✔ service2 Tests\OriNette\Console\Doubles\HiddenAndAliasedCommand
60+
service3 Tests\OriNette\Console\Doubles\SimpleCommand
6161
❌ ❌ service3 Symfony\Component\Console\Command\Command
6262

6363
MSG;

tests/Unit/DI/ConsoleExtensionTest.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -631,12 +631,12 @@ public function testCommandsDebugCommand(): void
631631
Following commands are missing ❌ either name or description. Check orisai/nette-console documentation about lazy loading to learn how to fix it.
632632
633633
Name Description Service name Service type
634-
❌ command.defaultName Tests\OriNette\Console\Doubles\DefaultNameCommand
635-
❌ command.tagged.name.a Tests\OriNette\Console\Doubles\SimpleCommand
636-
❌ command.tagged.name.b Tests\OriNette\Console\Doubles\SimpleCommand
637-
❌ command.tagged.name.c Tests\OriNette\Console\Doubles\SimpleCommand
638-
❌ command.hiddenAndAliased.negated Tests\OriNette\Console\Doubles\HiddenAndAliasedCommand
639-
❌ ✔ command.notLazy Symfony\Component\Console\Command\Command
634+
❌ command.defaultName Tests\OriNette\Console\Doubles\DefaultNameCommand
635+
❌ command.tagged.name.a Tests\OriNette\Console\Doubles\SimpleCommand
636+
❌ command.tagged.name.b Tests\OriNette\Console\Doubles\SimpleCommand
637+
❌ command.tagged.name.c Tests\OriNette\Console\Doubles\SimpleCommand
638+
❌ command.hiddenAndAliased.negated Tests\OriNette\Console\Doubles\HiddenAndAliasedCommand
639+
❌ ✔ command.notLazy Symfony\Component\Console\Command\Command
640640

641641
MSG;
642642

0 commit comments

Comments
 (0)