Create functions for setting and unsetting non public-set properties only once (performance optimization)

Author: mabar

CHANGELOG.md

@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 	- Simplify finding missing fields (performance optimization)
 	- Reduce calls needed to find field names for "did you mean" error helper (performance optimization)
 	- Call `unset()` only for initialized properties (performance optimization)
+	- Create functions for setting and unsetting non public-set properties only once (performance optimization)
 - `ArrayShapeRule`
 	- Simplify finding missing fields (performance optimization)
 	- Reduce calls needed to find field names for "did you mean" error helper (performance optimization)

src/Processing/DefaultProcessor.php

@@ -29,7 +29,6 @@
 use Orisai\ObjectMapper\Types\MappedObjectType;
 use Orisai\ObjectMapper\Types\MessageType;
 use Orisai\ObjectMapper\Types\Type;
-use ReflectionProperty;
 use function array_key_exists;
 use function array_keys;
 use function array_map;
@@ -51,7 +50,10 @@ final class DefaultProcessor implements Processor
 	private ServicesContext $services;
 
 	/** @var Closure(MappedObject, string, mixed): void */
-	private ?Closure $setterFunction;
+	private Closure $setFunction;
+
+	/** @var Closure(MappedObject, string): void */
+	private Closure $unsetFunction;
 
 	/** @var array<class-string<MappedObject>, RuntimeMeta> */
 	private array $metaCache = [];
@@ -67,9 +69,12 @@ public function __construct(MetaLoader $metaLoader, RuleManager $ruleManager, Ob
 		$this->rawValuesMap = new RawValuesMap();
 		$this->services = new ServicesContext($metaLoader, $ruleManager, $this);
 		// phpcs:disable SlevomatCodingStandard.Functions.StaticClosure
-		$this->setterFunction = function (MappedObject $object, string $name, $value): void {
+		$this->setFunction = function (MappedObject $object, string $name, $value): void {
 			$object->$name = $value;
 		};
+		$this->unsetFunction = function (MappedObject $object, string $name): void {
+			unset($object->$name);
+		};
 		// phpcs:enable
 	}
 
@@ -557,13 +562,29 @@ private function fillObject(
 		$fieldsMeta = $meta->fields;
 
 		if ($dynamic->getOptions()->getRequiredFields() === RequiredFields::none()) {
+			$unsetter = $this->unsetFunction;
+
 			// Reset mapped properties state
 			foreach ($fieldsMeta as $fieldMeta) {
-				$this->objectUnset($object, $fieldMeta->property);
+				$property = $fieldMeta->property;
+				$declaringClass = $property->getDeclaringClass();
+				$name = $property->getName();
+
+				if (
+					$property->isInitialized($object)
+					&& $property->isPublic()
+					&& (PHP_VERSION_ID < 8_01_00 || !$property->isReadOnly())
+				) {
+					unset($object->$name);
+				} else {
+					// phpcs:disable SlevomatCodingStandard.Functions.StaticClosure
+					$unsetter->bindTo($object, $declaringClass->getName())($object, $name);
+					// phpcs:enable
+				}
 			}
 		}
 
-		$setter = $this->setterFunction;
+		$setter = $this->setFunction;
 
 		// Set processed data
 		foreach ($data as $fieldName => $value) {
@@ -586,24 +607,4 @@ public function getRawValues(MappedObject $object)
 		return $this->rawValuesMap->getRawValues($object);
 	}
 
-	private function objectUnset(MappedObject $object, ReflectionProperty $property): void
-	{
-		$declaringClass = $property->getDeclaringClass();
-		$name = $property->getName();
-
-		if (
-			$property->isInitialized($object)
-			&& $property->isPublic()
-			&& (PHP_VERSION_ID < 8_01_00 || !$property->isReadOnly())
-		) {
-			unset($object->$name);
-		} else {
-			// phpcs:disable SlevomatCodingStandard.Functions.StaticClosure
-			(function () use ($object, $name): void {
-				unset($object->$name);
-			})->bindTo($object, $declaringClass->getName())();
-			// phpcs:enable
-		}
-	}
-
 }