Tests: use constants from rules in attribute object tests

mabar · mabar · commit f747821a2844 · 2025-02-19T23:07:06.000+01:00
diff --git a/tests/Unit/Callbacks/AfterTest.php b/tests/Unit/Callbacks/AfterTest.php
@@ -22,8 +22,8 @@ public function test(): void
 		self::assertSame(AfterCallback::class, $definition->getType());
 		self::assertSame(
 			[
-				'method' => $method,
-				'runtime' => 'process',
+				AfterCallback::Method => $method,
+				AfterCallback::Runtime => 'process',
 			],
 			$definition->getArgs(),
 		);
@@ -45,8 +45,8 @@ public function testVariant(string $method, string $runtime): void
 
 		self::assertEquals(
 			[
-				'method' => $method,
-				'runtime' => $runtime,
+				AfterCallback::Method => $method,
+				AfterCallback::Runtime => $runtime,
 			],
 			$definition->getArgs(),
 		);
diff --git a/tests/Unit/Callbacks/BeforeTest.php b/tests/Unit/Callbacks/BeforeTest.php
@@ -22,8 +22,8 @@ public function test(): void
 		self::assertSame(BeforeCallback::class, $definition->getType());
 		self::assertSame(
 			[
-				'method' => $method,
-				'runtime' => 'process',
+				BeforeCallback::Method => $method,
+				BeforeCallback::Runtime => 'process',
 			],
 			$definition->getArgs(),
 		);
@@ -45,8 +45,8 @@ public function testVariant(string $method, string $runtime): void
 
 		self::assertEquals(
 			[
-				'method' => $method,
-				'runtime' => $runtime,
+				BeforeCallback::Method => $method,
+				BeforeCallback::Runtime => $runtime,
 			],
 			$definition->getArgs(),
 		);
diff --git a/tests/Unit/Modifiers/DefaultValueTest.php b/tests/Unit/Modifiers/DefaultValueTest.php
@@ -22,7 +22,7 @@ public function test(): void
 		self::assertSame(DefaultValueModifier::class, $definition->getType());
 		self::assertSame(
 			[
-				'value' => $value,
+				DefaultValueModifier::Value => $value,
 			],
 			$definition->getArgs(),
 		);
diff --git a/tests/Unit/Modifiers/FieldNameTest.php b/tests/Unit/Modifiers/FieldNameTest.php
@@ -22,7 +22,7 @@ public function test(): void
 		self::assertSame(FieldNameModifier::class, $definition->getType());
 		self::assertSame(
 			[
-				'name' => $name,
+				FieldNameModifier::Name => $name,
 			],
 			$definition->getArgs(),
 		);
diff --git a/tests/Unit/Modifiers/RequiresDependenciesTest.php b/tests/Unit/Modifiers/RequiresDependenciesTest.php
@@ -22,7 +22,7 @@ public function test(): void
 		self::assertSame(RequiresDependenciesModifier::class, $definition->getType());
 		self::assertSame(
 			[
-				'injector' => DependenciesUsingVoInjector::class,
+				RequiresDependenciesModifier::Injector => DependenciesUsingVoInjector::class,
 			],
 			$definition->getArgs(),
 		);
diff --git a/tests/Unit/Rules/AllOfTest.php b/tests/Unit/Rules/AllOfTest.php
@@ -24,7 +24,7 @@ public function test(): void
 		self::assertSame(AllOfRule::class, $definition->getType());
 		self::assertEquals(
 			[
-				'rules' => [
+				AllOfRule::Rules => [
 					new RuleCompileMeta($sub1->getType(), $sub1->getArgs()),
 					new RuleCompileMeta($sub2->getType(), $sub2->getArgs()),
 				],
diff --git a/tests/Unit/Rules/AnyOfTest.php b/tests/Unit/Rules/AnyOfTest.php
@@ -24,7 +24,7 @@ public function test(): void
 		self::assertSame(AnyOfRule::class, $definition->getType());
 		self::assertEquals(
 			[
-				'rules' => [
+				AnyOfRule::Rules => [
 					new RuleCompileMeta($sub1->getType(), $sub1->getArgs()),
 					new RuleCompileMeta($sub2->getType(), $sub2->getArgs()),
 				],
diff --git a/tests/Unit/Rules/ArrayEnumValueTest.php b/tests/Unit/Rules/ArrayEnumValueTest.php
@@ -21,9 +21,9 @@ public function test(): void
 		self::assertSame(ArrayEnumRule::class, $definition->getType());
 		self::assertSame(
 			[
-				'cases' => $cases,
-				'useKeys' => false,
-				'allowUnknown' => false,
+				ArrayEnumRule::Cases => $cases,
+				ArrayEnumRule::UseKeys => false,
+				ArrayEnumRule::AllowUnknown => false,
 			],
 			$definition->getArgs(),
 		);
@@ -45,9 +45,9 @@ public function testVariant(array $cases, bool $useKeys, bool $allowUnknown): vo
 
 		self::assertEquals(
 			[
-				'cases' => $cases,
-				'useKeys' => $useKeys,
-				'allowUnknown' => $allowUnknown,
+				ArrayEnumRule::Cases => $cases,
+				ArrayEnumRule::UseKeys => $useKeys,
+				ArrayEnumRule::AllowUnknown => $allowUnknown,
 			],
 			$definition->getArgs(),
 		);
diff --git a/tests/Unit/Rules/ArrayOfTest.php b/tests/Unit/Rules/ArrayOfTest.php
@@ -26,11 +26,11 @@ public function test(): void
 		self::assertSame(ArrayOfRule::class, $definition->getType());
 		self::assertEquals(
 			[
-				'item' => new RuleCompileMeta($item->getType(), $item->getArgs()),
-				'minItems' => null,
-				'maxItems' => null,
-				'mergeDefaults' => false,
-				'key' => null,
+				ArrayOfRule::ItemRule => new RuleCompileMeta($item->getType(), $item->getArgs()),
+				ArrayOfRule::MinItems => null,
+				ArrayOfRule::MaxItems => null,
+				ArrayOfRule::MergeDefaults => false,
+				ArrayOfRule::KeyRule => null,
 			],
 			$definition->getArgs(),
 		);
@@ -56,11 +56,11 @@ public function testVariant(
 
 		self::assertEquals(
 			[
-				'item' => new RuleCompileMeta($item->getType(), $item->getArgs()),
-				'minItems' => $minItems,
-				'maxItems' => $maxItems,
-				'mergeDefaults' => $mergeDefaults,
-				'key' => $key === null ? null : new RuleCompileMeta($key->getType(), $key->getArgs()),
+				ArrayOfRule::ItemRule => new RuleCompileMeta($item->getType(), $item->getArgs()),
+				ArrayOfRule::MinItems => $minItems,
+				ArrayOfRule::MaxItems => $maxItems,
+				ArrayOfRule::MergeDefaults => $mergeDefaults,
+				ArrayOfRule::KeyRule => $key === null ? null : new RuleCompileMeta($key->getType(), $key->getArgs()),
 			],
 			$definition->getArgs(),
 		);
diff --git a/tests/Unit/Rules/ArrayShapeTest.php b/tests/Unit/Rules/ArrayShapeTest.php
@@ -27,7 +27,7 @@ public function test(): void
 		self::assertSame(ArrayShapeRule::class, $definition->getType());
 		self::assertEquals(
 			[
-				'fields' => [
+				ArrayShapeRule::Fields => [
 					'foo' => new RuleCompileMeta(
 						$fields['foo']->getType(),
 						$fields['foo']->getArgs(),
diff --git a/tests/Unit/Rules/BackedEnumValueTest.php b/tests/Unit/Rules/BackedEnumValueTest.php
@@ -27,8 +27,8 @@ public function test(): void
 		self::assertSame(BackedEnumRule::class, $definition->getType());
 		self::assertSame(
 			[
-				'class' => ExampleIntEnum::class,
-				'allowUnknown' => false,
+				BackedEnumRule::ClassName => ExampleIntEnum::class,
+				BackedEnumRule::AllowUnknown => false,
 			],
 			$definition->getArgs(),
 		);
@@ -47,8 +47,8 @@ public function testVariant(string $class, bool $allowUnknown): void
 
 		self::assertEquals(
 			[
-				'class' => $class,
-				'allowUnknown' => $allowUnknown,
+				BackedEnumRule::ClassName => $class,
+				BackedEnumRule::AllowUnknown => $allowUnknown,
 			],
 			$definition->getArgs(),
 		);
diff --git a/tests/Unit/Rules/BoolValueTest.php b/tests/Unit/Rules/BoolValueTest.php
@@ -20,7 +20,7 @@ public function test(): void
 		self::assertSame(BoolRule::class, $definition->getType());
 		self::assertSame(
 			[
-				'castBoolLike' => false,
+				BoolRule::CastBoolLike => false,
 			],
 			$definition->getArgs(),
 		);
@@ -40,7 +40,7 @@ public function testVariant(bool $castBoolLike): void
 
 		self::assertEquals(
 			[
-				'castBoolLike' => $castBoolLike,
+				BoolRule::CastBoolLike => $castBoolLike,
 			],
 			$definition->getArgs(),
 		);
diff --git a/tests/Unit/Rules/DateTimeValueTest.php b/tests/Unit/Rules/DateTimeValueTest.php
@@ -23,8 +23,8 @@ public function test(): void
 		self::assertSame(DateTimeRule::class, $definition->getType());
 		self::assertSame(
 			[
-				'class' => DateTimeImmutable::class,
-				'format' => 'iso_compat',
+				DateTimeRule::ClassName => DateTimeImmutable::class,
+				DateTimeRule::Format => 'iso_compat',
 			],
 			$definition->getArgs(),
 		);
@@ -46,8 +46,8 @@ public function testVariant(string $class, string $format): void
 
 		self::assertEquals(
 			[
-				'class' => $class,
-				'format' => $format,
+				DateTimeRule::ClassName => $class,
+				DateTimeRule::Format => $format,
 			],
 			$definition->getArgs(),
 		);
diff --git a/tests/Unit/Rules/FloatValueTest.php b/tests/Unit/Rules/FloatValueTest.php
@@ -20,10 +20,10 @@ public function test(): void
 		self::assertSame(FloatRule::class, $definition->getType());
 		self::assertSame(
 			[
-				'min' => null,
-				'max' => null,
-				'unsigned' => false,
-				'castNumericString' => false,
+				FloatRule::Min => null,
+				FloatRule::Max => null,
+				FloatRule::Unsigned => false,
+				FloatRule::CastNumericString => false,
 			],
 			$definition->getArgs(),
 		);
@@ -43,10 +43,10 @@ public function testVariant(?float $min, ?float $max, bool $unsigned, bool $cast
 
 		self::assertSame(
 			[
-				'min' => $min,
-				'max' => $max,
-				'unsigned' => $unsigned,
-				'castNumericString' => $castNumericString,
+				FloatRule::Min => $min,
+				FloatRule::Max => $max,
+				FloatRule::Unsigned => $unsigned,
+				FloatRule::CastNumericString => $castNumericString,
 			],
 			$definition->getArgs(),
 		);
diff --git a/tests/Unit/Rules/InstanceOfValueTest.php b/tests/Unit/Rules/InstanceOfValueTest.php
@@ -21,7 +21,7 @@ public function test(): void
 		self::assertSame(InstanceOfRule::class, $definition->getType());
 		self::assertSame(
 			[
-				'type' => $type,
+				InstanceOfRule::Type => $type,
 			],
 			$definition->getArgs(),
 		);
diff --git a/tests/Unit/Rules/IntValueTest.php b/tests/Unit/Rules/IntValueTest.php
@@ -20,10 +20,10 @@ public function test(): void
 		self::assertSame(IntRule::class, $definition->getType());
 		self::assertSame(
 			[
-				'min' => null,
-				'max' => null,
-				'unsigned' => false,
-				'castNumericString' => false,
+				IntRule::Min => null,
+				IntRule::Max => null,
+				IntRule::Unsigned => false,
+				IntRule::CastNumericString => false,
 			],
 			$definition->getArgs(),
 		);
@@ -43,10 +43,10 @@ public function testVariant(?int $min, ?int $max, bool $unsigned, bool $castNume
 
 		self::assertSame(
 			[
-				'min' => $min,
-				'max' => $max,
-				'unsigned' => $unsigned,
-				'castNumericString' => $castNumericString,
+				IntRule::Min => $min,
+				IntRule::Max => $max,
+				IntRule::Unsigned => $unsigned,
+				IntRule::CastNumericString => $castNumericString,
 			],
 			$definition->getArgs(),
 		);
diff --git a/tests/Unit/Rules/ListOfTest.php b/tests/Unit/Rules/ListOfTest.php
@@ -25,10 +25,10 @@ public function test(): void
 		self::assertSame(ListOfRule::class, $definition->getType());
 		self::assertEquals(
 			[
-				'item' => new RuleCompileMeta($item->getType(), $item->getArgs()),
-				'minItems' => null,
-				'maxItems' => null,
-				'mergeDefaults' => false,
+				ListOfRule::ItemRule => new RuleCompileMeta($item->getType(), $item->getArgs()),
+				ListOfRule::MinItems => null,
+				ListOfRule::MaxItems => null,
+				ListOfRule::MergeDefaults => false,
 			],
 			$definition->getArgs(),
 		);
@@ -48,10 +48,10 @@ public function testVariant(RuleDefinition $item, ?int $minItems, ?int $maxItems
 
 		self::assertEquals(
 			[
-				'item' => new RuleCompileMeta($item->getType(), $item->getArgs()),
-				'minItems' => $minItems,
-				'maxItems' => $maxItems,
-				'mergeDefaults' => $mergeDefaults,
+				ListOfRule::ItemRule => new RuleCompileMeta($item->getType(), $item->getArgs()),
+				ListOfRule::MinItems => $minItems,
+				ListOfRule::MaxItems => $maxItems,
+				ListOfRule::MergeDefaults => $mergeDefaults,
 			],
 			$definition->getArgs(),
 		);
diff --git a/tests/Unit/Rules/MappedObjectValueTest.php b/tests/Unit/Rules/MappedObjectValueTest.php
@@ -20,7 +20,7 @@ public function test(): void
 		self::assertSame(MappedObjectRule::class, $definition->getType());
 		self::assertSame(
 			[
-				'class' => DefaultsVO::class,
+				MappedObjectRule::ClassName => DefaultsVO::class,
 			],
 			$definition->getArgs(),
 		);
diff --git a/tests/Unit/Rules/NullValueTest.php b/tests/Unit/Rules/NullValueTest.php
@@ -20,7 +20,7 @@ public function test(): void
 		self::assertSame(NullRule::class, $definition->getType());
 		self::assertSame(
 			[
-				'castEmptyString' => false,
+				NullRule::CastEmptyString => false,
 			],
 			$definition->getArgs(),
 		);
@@ -40,7 +40,7 @@ public function testVariant(bool $castEmptyString): void
 
 		self::assertEquals(
 			[
-				'castEmptyString' => $castEmptyString,
+				NullRule::CastEmptyString => $castEmptyString,
 			],
 			$definition->getArgs(),
 		);
diff --git a/tests/Unit/Rules/StringValueTest.php b/tests/Unit/Rules/StringValueTest.php
@@ -20,11 +20,11 @@ public function test(): void
 		self::assertSame(StringRule::class, $definition->getType());
 		self::assertSame(
 			[
-				'pattern' => null,
-				'minLength' => null,
-				'maxLength' => null,
-				'notEmpty' => false,
-				'trim' => false,
+				StringRule::Pattern => null,
+				StringRule::MinLength => null,
+				StringRule::MaxLength => null,
+				StringRule::NotEmpty => false,
+				StringRule::Trim => false,
 			],
 			$definition->getArgs(),
 		);
@@ -44,11 +44,11 @@ public function testVariant(?string $pattern, ?int $minLength, ?int $maxLength,
 
 		self::assertEquals(
 			[
-				'pattern' => $pattern,
-				'minLength' => $minLength,
-				'maxLength' => $maxLength,
-				'notEmpty' => $notEmpty,
-				'trim' => $trim,
+				StringRule::Pattern => $pattern,
+				StringRule::MinLength => $minLength,
+				StringRule::MaxLength => $maxLength,
+				StringRule::NotEmpty => $notEmpty,
+				StringRule::Trim => $trim,
 			],
 			$definition->getArgs(),
 		);

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ public function test(): void`
`22`	`22`	`self::assertSame(DefaultValueModifier::class, $definition->getType());`
`23`	`23`	`self::assertSame(`
`24`	`24`	`[`
`25`		`- 'value' => $value,`
	`25`	`+ DefaultValueModifier::Value => $value,`
`26`	`26`	`],`
`27`	`27`	`$definition->getArgs(),`
`28`	`28`	`);`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ public function test(): void`
`24`	`24`	`self::assertSame(AllOfRule::class, $definition->getType());`
`25`	`25`	`self::assertEquals(`
`26`	`26`	`[`
`27`		`- 'rules' => [`
	`27`	`+ AllOfRule::Rules => [`
`28`	`28`	`new RuleCompileMeta($sub1->getType(), $sub1->getArgs()),`
`29`	`29`	`new RuleCompileMeta($sub2->getType(), $sub2->getArgs()),`
`30`	`30`	`],`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ public function test(): void`
`27`	`27`	`self::assertSame(ArrayShapeRule::class, $definition->getType());`
`28`	`28`	`self::assertEquals(`
`29`	`29`	`[`
`30`		`- 'fields' => [`
	`30`	`+ ArrayShapeRule::Fields => [`
`31`	`31`	`'foo' => new RuleCompileMeta(`
`32`	`32`	`$fields['foo']->getType(),`
`33`	`33`	`$fields['foo']->getArgs(),`