Wrap service calls in try-catch blocks

Author: ormesam

src/Tracked/Contexts/UIContext.cs

@@ -77,8 +77,9 @@ public async Task GoToRecordScreenAsync() {
 
         public async Task GoToRideReviewScreenAsync(int id) {
             RideReviewScreenViewModel viewModel = new RideReviewScreenViewModel(context);
-            await viewModel.Load(id);
-            await GoToScreenAsync(new RideReviewScreen(viewModel));
+            if (await viewModel.Load(id)) {
+                await GoToScreenAsync(new RideReviewScreen(viewModel));
+            }
         }
 
         public async Task GoToMapScreenAsync(RideDto ride) {
@@ -91,8 +92,9 @@ public async Task GoToCreateTrailScreenAsync(RideDto ride = null) {
 
         public async Task GoToTrailScreenAsync(int trailId) {
             TrailScreenViewModel viewModel = new TrailScreenViewModel(context);
-            await viewModel.Load(trailId);
-            await GoToScreenAsync(new TrailScreen(viewModel));
+            if (await viewModel.Load(trailId)) {
+                await GoToScreenAsync(new TrailScreen(viewModel));
+            }
         }
 
         public async Task GoToSpeedAnalysisScreenAsync(IList<RideLocationDto> rideLocation) {
@@ -101,8 +103,9 @@ public async Task GoToSpeedAnalysisScreenAsync(IList<RideLocationDto> rideLocati
 
         public async Task GoToProfileScreenAsync() {
             var viewModel = new ProfileScreenViewModel(context);
-            await viewModel.Load();
-            await ReplaceScreenAsync(new ProfileScreen(viewModel));
+            if (await viewModel.Load()) {
+                await ReplaceScreenAsync(new ProfileScreen(viewModel));
+            }
         }
 
         public async Task GoToSettingsScreenAsync() {

src/Tracked/Screens/Profile/ProfileScreenViewModel.cs

@@ -2,6 +2,7 @@
 using Shared.Dtos;
 using Tracked.Contexts;
 using Tracked.Models;
+using Tracked.Utilities;
 
 namespace Tracked.Screens.Profile {
     public class ProfileScreenViewModel : TabbedViewModelBase {
@@ -51,8 +52,16 @@ public string Bio {
 
         public override string Title => IsCurrentUser ? "Profile" : User.Name;
 
-        public async Task Load() {
-            User = await Context.Services.GetProfile();
+        public async Task<bool> Load() {
+            try {
+                User = await Context.Services.GetProfile();
+
+                return true;
+            } catch (ServiceException ex) {
+                Toast.LongAlert(ex.Message);
+
+                return false;
+            }
         }
 
         public async Task EditBio() {
@@ -62,11 +71,15 @@ public async Task EditBio() {
                 return;
             }
 
-            await Context.Services.UpdateBio(newBio);
+            try {
+                await Context.Services.UpdateBio(newBio);
 
-            User.Bio = newBio;
+                User.Bio = newBio;
 
-            OnPropertyChanged(nameof(Bio));
+                OnPropertyChanged(nameof(Bio));
+            } catch (ServiceException ex) {
+                Toast.LongAlert(ex.Message);
+            }
         }
 
         public async Task GoToSettings() {

src/Tracked/Screens/Rides/RideReviewScreenViewModel.cs

@@ -4,6 +4,7 @@
 using System.Threading.Tasks;
 using Shared.Dtos;
 using Tracked.Contexts;
+using Tracked.Utilities;
 
 namespace Tracked.Screens.Rides {
     public class RideReviewScreenViewModel : RideMapViewModelBase {
@@ -28,10 +29,18 @@ public RideReviewScreenViewModel(MainContext context) : base(context) {
         public IList<AchievementDto> Achievements => Ride.Achievements;
         public bool CanCreateTrail => Context.Security.IsAdmin;
 
-        public async Task Load(int id) {
-            ride = await Context.Services.GetRide(id);
+        public async Task<bool> Load(int id) {
+            try {
+                ride = await Context.Services.GetRide(id);
 
-            OnPropertyChanged();
+                OnPropertyChanged();
+
+                return true;
+            } catch (ServiceException ex) {
+                Toast.LongAlert(ex.Message);
+
+                return false;
+            }
         }
 
         private async void MapViewModel_MapControlTapped(object sender, EventArgs e) {
@@ -51,7 +60,11 @@ public async Task CreateTrail() {
         }
 
         public async Task Delete() {
-            await Context.Services.DeleteRide(Ride.RideId.Value);
+            try {
+                await Context.Services.DeleteRide(Ride.RideId.Value);
+            } catch (ServiceException ex) {
+                Toast.LongAlert(ex.Message);
+            }
         }
 
         public async Task GoToMapScreen() {

src/Tracked/Screens/Trails/CreateTrailScreenViewModel.cs

@@ -60,9 +60,13 @@ public async Task Save(INavigation nav) {
 
             trail.Name = newName;
 
-            await Context.Services.UploadTrail(trail);
+            try {
+                await Context.Services.UploadTrail(trail);
 
-            await nav.PopAsync();
+                await nav.PopAsync();
+            } catch (ServiceException ex) {
+                Toast.LongAlert(ex.Message);
+            }
         }
 
         public void AddPin(double latitude, double longitude) {

src/Tracked/Screens/Trails/TrailScreenViewModel.cs

@@ -26,10 +26,18 @@ public TrailDto Trail {
             }
         }
 
-        public async Task Load(int id) {
-            Trail = await Context.Services.GetTrail(id);
+        public async Task<bool> Load(int id) {
+            try {
+                Trail = await Context.Services.GetTrail(id);
 
-            OnPropertyChanged();
+                OnPropertyChanged();
+
+                return true;
+            } catch (ServiceException ex) {
+                Toast.LongAlert(ex.Message);
+
+                return false;
+            }
         }
 
         public async Task ChangeName() {
@@ -44,12 +52,21 @@ public async Task ChangeName() {
             OnPropertyChanged(nameof(Title));
             OnPropertyChanged(nameof(Trail));
 
-            await Context.Services.ChangeTrailName(Trail.TrailId.Value, newName);
+            try {
+                await Context.Services.ChangeTrailName(Trail.TrailId.Value, newName);
+            } catch (ServiceException ex) {
+                Toast.LongAlert(ex.Message);
+            }
         }
 
         public async Task Delete() {
-            await Context.Services.DeleteTrail(Trail.TrailId.Value);
+            try {
+                await Context.Services.DeleteTrail(Trail.TrailId.Value);
+            } catch (ServiceException ex) {
+                Toast.LongAlert(ex.Message);
+            }
         }
+
         protected override ILatLng Centre => Trail.Locations.Midpoint();
 
         protected override IEnumerable<MapPin> GetPins() {