Add link to settings page from the recording screen

Author: ormesam

src/Tracked/Screens/Record/RecordScreen.xaml

@@ -5,6 +5,12 @@
     xmlns:controls="clr-namespace:Tracked.Controls"
     x:Class="Tracked.Screens.Record.RecordScreen"
     Title="{Binding Title}">
+    <ContentPage.ToolbarItems>
+        <ToolbarItem
+            Text="Settings"
+            Order="Primary"
+            Clicked="Settings_Tapped" />
+    </ContentPage.ToolbarItems>
     <ContentPage.Content>
         <Grid
             RowSpacing="0">

src/Tracked/Screens/Record/RecordScreen.xaml.cs

@@ -17,6 +17,8 @@ protected override async void OnAppearing() {
             base.OnAppearing();
 
             await ViewModel.StartLocationListening();
+
+            ViewModel.OnPropertyChanged();
         }
 
         protected override async void OnDisappearing() {
@@ -33,5 +35,9 @@ private async void Stop_Clicked(object sender, EventArgs e) {
             await ViewModel.Stop();
             await Navigation.PopToRootAsync();
         }
+
+        private async void Settings_Tapped(object sender, EventArgs e) {
+            await ViewModel.GoToSettings();
+        }
     }
 }

src/Tracked/Screens/Record/RecordScreenViewModel.cs

@@ -12,15 +12,13 @@
 namespace Tracked.Screens.Record {
     public class RecordScreenViewModel : ViewModelBase {
         private readonly RideRecorder rideRecorder;
-        private readonly bool shouldDetectJumps;
         private readonly Timer timer;
 
         private RecordStatus status;
         private bool hasAcquiredGpsSignal;
 
         public RecordScreenViewModel(MainContext context) : base(context) {
             rideRecorder = new RideRecorder(Context);
-            shouldDetectJumps = context.Settings.ShouldDetectJumps;
             status = RecordStatus.NotStarted;
             timer = new Timer();
             timer.Elapsed += Timer_Elapsed;
@@ -70,9 +68,9 @@ public string TimerDisplay {
 
         public bool ShowNotifications => Status == RecordStatus.NotStarted;
 
-        public string AccelerometerNotification => shouldDetectJumps ? "Detecting Jumps" : "Not Detecting Jumps";
+        public string AccelerometerNotification => ShouldDetectJumps ? "Detecting Jumps" : "Not Detecting Jumps";
 
-        public bool ShouldDetectJumps => shouldDetectJumps;
+        public bool ShouldDetectJumps => Context.Settings.ShouldDetectJumps;
 
         public RecordStatus Status {
             get { return status; }
@@ -133,5 +131,9 @@ public async Task StopLocationListening() {
 
             DependencyService.Get<INativeForegroundService>().Stop();
         }
+
+        public async Task GoToSettings() {
+            await Context.UI.GoToSettingsScreenAsync();
+        }
     }
 }

src/Tracked/Utilities/NotifyPropertyChangedBase.cs

@@ -1,18 +1,14 @@
 using System.ComponentModel;
 
-namespace Tracked.Utilities
-{
-    public class NotifyPropertyChangedBase : INotifyPropertyChanged
-    {
+namespace Tracked.Utilities {
+    public class NotifyPropertyChangedBase : INotifyPropertyChanged {
         public event PropertyChangedEventHandler PropertyChanged;
 
-        protected void OnPropertyChanged()
-        {
+        public void OnPropertyChanged() {
             OnPropertyChanged(null);
         }
 
-        protected virtual void OnPropertyChanged(string propertyName)
-        {
+        protected virtual void OnPropertyChanged(string propertyName) {
             PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
         }
     }