Skip to content

Commit 10dc05d

Browse files
authored
Merge pull request #491 from orottier/feature/audio-processor-destructor
Code reorganization of src/node/mod.rs
2 parents 0a50410 + 7123042 commit 10dc05d

File tree

6 files changed

+720
-716
lines changed

6 files changed

+720
-716
lines changed

src/node/audio_buffer_source.rs

Lines changed: 0 additions & 98 deletions
Original file line numberDiff line numberDiff line change
@@ -785,9 +785,6 @@ mod tests {
785785
use float_eq::assert_float_eq;
786786
use std::f32::consts::PI;
787787

788-
use std::sync::atomic::{AtomicBool, Ordering};
789-
use std::sync::Arc;
790-
791788
use crate::context::{BaseAudioContext, OfflineAudioContext};
792789
use crate::RENDER_QUANTUM_SIZE;
793790

@@ -1441,99 +1438,4 @@ mod tests {
14411438

14421439
assert_float_eq!(channel[..], expected[..], abs_all <= 0.);
14431440
}
1444-
1445-
#[test]
1446-
#[should_panic]
1447-
fn test_start_twice() {
1448-
let context = OfflineAudioContext::new(2, 1, 44_100.);
1449-
let mut src = context.create_buffer_source();
1450-
src.start();
1451-
src.start();
1452-
}
1453-
1454-
#[test]
1455-
#[should_panic]
1456-
fn test_stop_before_start() {
1457-
let context = OfflineAudioContext::new(2, 1, 44_100.);
1458-
let mut src = context.create_buffer_source();
1459-
src.stop();
1460-
}
1461-
1462-
#[test]
1463-
#[should_panic]
1464-
fn test_stop_twice() {
1465-
let context = OfflineAudioContext::new(2, 1, 44_100.);
1466-
let mut src = context.create_buffer_source();
1467-
src.start();
1468-
src.stop();
1469-
src.stop();
1470-
}
1471-
1472-
#[test]
1473-
fn test_ended_event() {
1474-
let mut context = OfflineAudioContext::new(2, 44_100, 44_100.);
1475-
let mut src = context.create_buffer_source();
1476-
src.start_at(0.);
1477-
src.stop_at(0.5);
1478-
1479-
let ended = Arc::new(AtomicBool::new(false));
1480-
let ended_clone = Arc::clone(&ended);
1481-
src.set_onended(move |_event| {
1482-
ended_clone.store(true, Ordering::Relaxed);
1483-
});
1484-
1485-
let _ = context.start_rendering_sync();
1486-
assert!(ended.load(Ordering::Relaxed));
1487-
}
1488-
1489-
#[test]
1490-
fn test_no_ended_event() {
1491-
let mut context = OfflineAudioContext::new(2, 44_100, 44_100.);
1492-
let src = context.create_constant_source();
1493-
1494-
// do not start the node
1495-
1496-
let ended = Arc::new(AtomicBool::new(false));
1497-
let ended_clone = Arc::clone(&ended);
1498-
src.set_onended(move |_event| {
1499-
ended_clone.store(true, Ordering::Relaxed);
1500-
});
1501-
1502-
let _ = context.start_rendering_sync();
1503-
assert!(!ended.load(Ordering::Relaxed)); // should not have triggered
1504-
}
1505-
1506-
#[test]
1507-
fn test_exact_ended_event() {
1508-
let mut context = OfflineAudioContext::new(2, 44_100, 44_100.);
1509-
let mut src = context.create_buffer_source();
1510-
src.start_at(0.);
1511-
src.stop_at(1.); // end right at the end of the offline buffer
1512-
1513-
let ended = Arc::new(AtomicBool::new(false));
1514-
let ended_clone = Arc::clone(&ended);
1515-
src.set_onended(move |_event| {
1516-
ended_clone.store(true, Ordering::Relaxed);
1517-
});
1518-
1519-
let _ = context.start_rendering_sync();
1520-
assert!(ended.load(Ordering::Relaxed));
1521-
}
1522-
1523-
#[test]
1524-
fn test_implicit_ended_event() {
1525-
let mut context = OfflineAudioContext::new(2, 44_100, 44_100.);
1526-
let mut src = context.create_buffer_source();
1527-
src.start_at(0.);
1528-
// no explicit stop, so we stop at end of offline context
1529-
1530-
let ended = Arc::new(AtomicBool::new(false));
1531-
let ended_clone = Arc::clone(&ended);
1532-
src.set_onended(move |_event| {
1533-
ended_clone.store(true, Ordering::Relaxed);
1534-
});
1535-
1536-
let _ = context.start_rendering_sync();
1537-
assert!(ended.load(Ordering::Relaxed));
1538-
}
15391441
}

0 commit comments

Comments
 (0)