Merge pull request #326 from uklotzde/feature/worklet-example

onmessage: Either consume and handle or drop incoming messages

Author: orottier

examples/worklet.rs

@@ -143,13 +143,17 @@ impl AudioProcessor for WhiteNoiseProcessor {
 
     fn onmessage(&mut self, msg: Box<dyn std::any::Any + Send + 'static>) {
         // handle incoming signals requesting for change of color
-        if let Some(&color) = msg.downcast_ref::<NoiseColor>() {
-            self.color = color;
-            return;
-        }
+        let msg = match msg.downcast::<NoiseColor>() {
+            Ok(color) => {
+                self.color = *color;
+                return;
+            }
+            Err(msg) => msg,
+        };
 
-        // ignore other incoming messages
-        log::warn!("WhiteNoiseProcessor: Ignoring incoming message");
+        // ...add more message handlers here...
+
+        log::warn!("WhiteNoiseProcessor: Dropping incoming message {msg:?}");
     }
 }
 

src/node/audio_buffer_source.rs

@@ -341,6 +341,22 @@ struct AudioBufferSourceRenderer {
     ended_triggered: bool,
 }
 
+impl AudioBufferSourceRenderer {
+    fn handle_control_message(&mut self, control: Control) {
+        match control {
+            Control::StartWithOffsetAndDuration(start, offset, duration) => {
+                self.start_time = start;
+                self.offset = offset;
+                self.duration = duration;
+            }
+            Control::Stop(v) => self.stop_time = v,
+            Control::Loop(v) => self.controller.set_loop(v),
+            Control::LoopStart(v) => self.controller.set_loop_start(v),
+            Control::LoopEnd(v) => self.controller.set_loop_end(v),
+        }
+    }
+}
+
 impl AudioProcessor for AudioBufferSourceRenderer {
     fn process(
         &mut self,
@@ -701,26 +717,23 @@ impl AudioProcessor for AudioBufferSourceRenderer {
     }
 
     fn onmessage(&mut self, msg: Box<dyn std::any::Any + Send + 'static>) {
-        if let Some(&control) = msg.downcast_ref::<Control>() {
-            match control {
-                Control::StartWithOffsetAndDuration(start, offset, duration) => {
-                    self.start_time = start;
-                    self.offset = offset;
-                    self.duration = duration;
-                }
-                Control::Stop(v) => self.stop_time = v,
-                Control::Loop(v) => self.controller.set_loop(v),
-                Control::LoopStart(v) => self.controller.set_loop_start(v),
-                Control::LoopEnd(v) => self.controller.set_loop_end(v),
+        let msg = match msg.downcast::<Control>() {
+            Ok(control) => {
+                self.handle_control_message(*control);
+                return;
             }
-        }
+            Err(msg) => msg,
+        };
 
-        if let Ok(buffer) = msg.downcast::<AudioBuffer>() {
-            self.buffer = Some(*buffer);
-            return;
-        }
+        let msg = match msg.downcast::<AudioBuffer>() {
+            Ok(buffer) => {
+                self.buffer = Some(*buffer);
+                return;
+            }
+            Err(msg) => msg,
+        };
 
-        log::warn!("AudioBufferSourceRenderer: Ignoring incoming message");
+        log::warn!("AudioBufferSourceRenderer: Dropping incoming message {msg:?}");
     }
 }
 

src/node/constant_source.rs

@@ -203,14 +203,18 @@ impl AudioProcessor for ConstantSourceRenderer {
     }
 
     fn onmessage(&mut self, msg: Box<dyn std::any::Any + Send + 'static>) {
-        if let Ok(schedule) = msg.downcast::<Schedule>() {
-            match *schedule {
-                Schedule::Start(v) => self.start_time = v,
-                Schedule::Stop(v) => self.stop_time = v,
+        let msg = match msg.downcast::<Schedule>() {
+            Ok(schedule) => {
+                match *schedule {
+                    Schedule::Start(v) => self.start_time = v,
+                    Schedule::Stop(v) => self.stop_time = v,
+                }
+                return;
             }
-        }
+            Err(msg) => msg,
+        };
 
-        log::warn!("ConstantSourceRenderer: Ignoring incoming message");
+        log::warn!("ConstantSourceRenderer: Dropping incoming message {msg:?}");
     }
 }
 

src/node/oscillator.rs

@@ -432,27 +432,36 @@ impl AudioProcessor for OscillatorRenderer {
     }
 
     fn onmessage(&mut self, msg: Box<dyn std::any::Any + Send + 'static>) {
-        if let Some(&type_) = msg.downcast_ref::<OscillatorType>() {
-            self.shared_type.store(type_ as u32, Ordering::Release);
-            self.type_ = type_;
-            return;
-        }
+        let msg = match msg.downcast::<OscillatorType>() {
+            Ok(type_) => {
+                self.shared_type.store(*type_ as u32, Ordering::Release);
+                self.type_ = *type_;
+                return;
+            }
+            Err(msg) => msg,
+        };
 
-        if let Some(&schedule) = msg.downcast_ref::<Schedule>() {
-            match schedule {
-                Schedule::Start(v) => self.start_time = v,
-                Schedule::Stop(v) => self.stop_time = v,
+        let msg = match msg.downcast::<Schedule>() {
+            Ok(schedule) => {
+                match *schedule {
+                    Schedule::Start(v) => self.start_time = v,
+                    Schedule::Stop(v) => self.stop_time = v,
+                }
+                return;
             }
-            return;
-        }
+            Err(msg) => msg,
+        };
 
-        if let Ok(periodic_wave) = msg.downcast::<PeriodicWave>() {
-            self.periodic_wave = Some(*periodic_wave);
-            self.type_ = OscillatorType::Custom; // shared type is already updated by control
-            return;
-        }
+        let msg = match msg.downcast::<PeriodicWave>() {
+            Ok(periodic_wave) => {
+                self.periodic_wave = Some(*periodic_wave);
+                self.type_ = OscillatorType::Custom; // shared type is already updated by control
+                return;
+            }
+            Err(msg) => msg,
+        };
 
-        log::warn!("OscillatorRenderer: Ignoring incoming message");
+        log::warn!("OscillatorRenderer: Dropping incoming message {msg:?}");
     }
 }
 

src/param.rs

@@ -642,16 +642,24 @@ impl AudioProcessor for AudioParamProcessor {
     }
 
     fn onmessage(&mut self, msg: Box<dyn std::any::Any + Send + 'static>) {
-        if let Some(&automation_rate) = msg.downcast_ref::<AutomationRate>() {
-            self.automation_rate = automation_rate;
-            self.shared_parts.store_automation_rate(automation_rate);
-            return;
-        }
+        let msg = match msg.downcast::<AutomationRate>() {
+            Ok(automation_rate) => {
+                self.automation_rate = *automation_rate;
+                self.shared_parts.store_automation_rate(*automation_rate);
+                return;
+            }
+            Err(msg) => msg,
+        };
 
-        match msg.downcast::<AudioParamEvent>() {
-            Ok(event) => self.handle_incoming_event(*event),
-            _ => log::warn!("AudioParamProcessor: Ignoring incoming message"),
-        }
+        let msg = match msg.downcast::<AudioParamEvent>() {
+            Ok(event) => {
+                self.handle_incoming_event(*event);
+                return;
+            }
+            Err(msg) => msg,
+        };
+
+        log::warn!("AudioParamProcessor: Dropping incoming message {msg:?}");
     }
 }