Add Debug for MediaElement, enforce lint at node mode

Author: orottier

src/media_element.rs

@@ -19,6 +19,14 @@ pub(crate) struct RTSStream {
     playback_rate: Arc<AtomicF64>,
 }
 
+impl std::fmt::Debug for RTSStream {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        f.debug_struct("RTSStream")
+            .field("number_of_channels", &self.number_of_channels)
+            .finish_non_exhaustive()
+    }
+}
+
 /// Controller actions for a media element
 pub(crate) enum MediaElementAction {
     /// Seek to the given timestamp
@@ -46,6 +54,18 @@ pub struct MediaElement {
     playback_rate: Arc<AtomicF64>,
 }
 
+impl std::fmt::Debug for MediaElement {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        f.debug_struct("MediaElement")
+            .field("stream", &self.stream)
+            .field("current_time", &self.current_time())
+            .field("loop", &self.loop_())
+            .field("paused", &self.paused())
+            .field("playback_rate", &self.playback_rate())
+            .finish_non_exhaustive()
+    }
+}
+
 impl MediaElement {
     /// Create a new instance for a given file path
     pub fn new<P: Into<PathBuf>>(file: P) -> Result<Self, Box<dyn Error>> {

src/node/media_element_source.rs

@@ -13,6 +13,7 @@ use super::{AudioNode, ChannelConfig, MediaStreamRenderer};
 // @note - Does not extend AudioNodeOptions because AudioNodeOptions are
 // useless for source nodes as they instruct how to upmix the inputs.
 // This is a common source of confusion, see e.g. https://github.com/mdn/content/pull/18472
+#[derive(Debug)]
 pub struct MediaElementAudioSourceOptions<'a> {
     pub media_element: &'a mut MediaElement,
 }

src/node/media_stream_source.rs

@@ -13,6 +13,7 @@ use super::{AudioNode, ChannelConfig, MediaStreamRenderer};
 // @note - Does not extend AudioNodeOptions because AudioNodeOptions are
 // useless for source nodes as they instruct how to upmix the inputs.
 // This is a common source of confusion, see e.g. https://github.com/mdn/content/pull/18472
+#[derive(Debug)]
 pub struct MediaStreamAudioSourceOptions<'a> {
     pub media_stream: &'a MediaStream,
 }

src/node/media_stream_track_source.rs

@@ -13,6 +13,7 @@ use super::{AudioNode, ChannelConfig, MediaStreamRenderer};
 // @note - Does not extend AudioNodeOptions because AudioNodeOptions are
 // useless for source nodes as they instruct how to upmix the inputs.
 // This is a common source of confusion, see e.g. https://github.com/mdn/content/pull/18472
+#[derive(Debug)]
 pub struct MediaStreamTrackAudioSourceOptions<'a> {
     pub media_stream_track: &'a MediaStreamTrack,
 }

src/node/mod.rs

@@ -1,4 +1,7 @@
 //! The AudioNode interface and concrete types
+
+#![deny(missing_debug_implementations)]
+
 use std::f32::consts::PI;
 use std::sync::{Arc, Mutex, OnceLock};