ScriptProcessorNode: tailTime false suffices (and is spec compliant)

orottier · orottier · commit 829573451174 · 2024-04-09T08:40:47.000+02:00
diff --git a/src/node/script_processor.rs b/src/node/script_processor.rs
@@ -246,10 +246,7 @@ impl AudioProcessor for ScriptProcessorRenderer {
             self.next_output_buffer.resize(number_of_quanta, silence);
         }
 
-        // TODO, spec says to return false but we actually need true because of 'actively
-        // processing' requirements
-        // <https://webaudio.github.io/web-audio-api/#AudioNode-actively-processing>
-        true
+        false // node is kept alive as long as the handle in the event loop still exists
     }
 
     fn onmessage(&mut self, msg: &mut dyn Any) {

Original file line number	Diff line number	Diff line change
`@@ -246,10 +246,7 @@ impl AudioProcessor for ScriptProcessorRenderer {`
`246`	`246`	`self.next_output_buffer.resize(number_of_quanta, silence);`
`247`	`247`	`}`
`248`	`248`
`249`		`- // TODO, spec says to return false but we actually need true because of 'actively`
`250`		`- // processing' requirements`
`251`		`- // <https://webaudio.github.io/web-audio-api/#AudioNode-actively-processing>`
`252`		`- true`
	`249`	`+ false // node is kept alive as long as the handle in the event loop still exists`
`253`	`250`	`}`
`254`	`251`
`255`	`252`	`fn onmessage(&mut self, msg: &mut dyn Any) {`