Make post_message generic, so users don't need to Box themselves

Author: orottier

src/context/mod.rs

@@ -105,8 +105,11 @@ impl AudioContextRegistration {
     ///
     /// The message will be handled by
     /// [`AudioProcessor::onmessage`](crate::render::AudioProcessor::onmessage).
-    pub fn post_message(&self, msg: Box<dyn std::any::Any + Send + 'static>) {
-        let wrapped = crate::message::ControlMessage::NodeMessage { id: self.id, msg };
+    pub fn post_message<M: std::any::Any + Send + 'static>(&self, msg: M) {
+        let wrapped = crate::message::ControlMessage::NodeMessage {
+            id: self.id,
+            msg: Box::new(msg),
+        };
         let _ = self.context.send_control_msg(wrapped);
     }
 }

src/node/audio_buffer_source.rs

@@ -139,8 +139,7 @@ impl AudioScheduledSourceNode for AudioBufferSourceNode {
             panic!("InvalidStateError cannot stop before start");
         }
 
-        self.registration
-            .post_message(Box::new(Control::Stop(when)));
+        self.registration.post_message(Control::Stop(when));
     }
 }
 
@@ -239,7 +238,7 @@ impl AudioBufferSourceNode {
         }
 
         let control = Control::StartWithOffsetAndDuration(start, offset, duration);
-        self.registration.post_message(Box::new(control));
+        self.registration.post_message(control);
     }
 
     /// Current buffer value (nullable)
@@ -260,7 +259,7 @@ impl AudioBufferSourceNode {
             panic!("InvalidStateError - cannot assign buffer twice");
         }
 
-        self.registration.post_message(Box::new(clone));
+        self.registration.post_message(clone);
     }
 
     /// K-rate [`AudioParam`] that defines the speed at which the [`AudioBuffer`]
@@ -287,8 +286,7 @@ impl AudioBufferSourceNode {
     }
 
     pub fn set_loop(&self, value: bool) {
-        self.registration
-            .post_message(Box::new(Control::Loop(value)));
+        self.registration.post_message(Control::Loop(value));
     }
 
     /// Defines the loop start point, in the time reference of the [`AudioBuffer`]
@@ -297,8 +295,7 @@ impl AudioBufferSourceNode {
     }
 
     pub fn set_loop_start(&self, value: f64) {
-        self.registration
-            .post_message(Box::new(Control::LoopStart(value)));
+        self.registration.post_message(Control::LoopStart(value));
     }
 
     /// Defines the loop end point, in the time reference of the [`AudioBuffer`]
@@ -307,8 +304,7 @@ impl AudioBufferSourceNode {
     }
 
     pub fn set_loop_end(&self, value: f64) {
-        self.registration
-            .post_message(Box::new(Control::LoopEnd(value)));
+        self.registration.post_message(Control::LoopEnd(value));
     }
 }
 

src/node/constant_source.rs

@@ -92,8 +92,7 @@ impl AudioScheduledSourceNode for ConstantSourceNode {
     }
 
     fn start_at(&self, when: f64) {
-        self.registration
-            .post_message(Box::new(Schedule::Start(when)));
+        self.registration.post_message(Schedule::Start(when));
     }
 
     fn stop(&self) {
@@ -102,8 +101,7 @@ impl AudioScheduledSourceNode for ConstantSourceNode {
     }
 
     fn stop_at(&self, when: f64) {
-        self.registration
-            .post_message(Box::new(Schedule::Stop(when)));
+        self.registration.post_message(Schedule::Stop(when));
     }
 }
 

src/node/oscillator.rs

@@ -156,8 +156,7 @@ impl AudioScheduledSourceNode for OscillatorNode {
     }
 
     fn start_at(&self, when: f64) {
-        self.registration
-            .post_message(Box::new(Schedule::Start(when)));
+        self.registration.post_message(Schedule::Start(when));
     }
 
     fn stop(&self) {
@@ -166,8 +165,7 @@ impl AudioScheduledSourceNode for OscillatorNode {
     }
 
     fn stop_at(&self, when: f64) {
-        self.registration
-            .post_message(Box::new(Schedule::Stop(when)));
+        self.registration.post_message(Schedule::Stop(when));
     }
 }
 
@@ -290,7 +288,7 @@ impl OscillatorNode {
             return;
         }
 
-        self.registration.post_message(Box::new(type_));
+        self.registration.post_message(type_);
     }
 
     /// Sets a `PeriodicWave` which describes a waveform to be used by the oscillator.
@@ -303,7 +301,7 @@ impl OscillatorNode {
         self.shared_type
             .store(OscillatorType::Custom as u32, Ordering::Release);
 
-        self.registration.post_message(Box::new(periodic_wave));
+        self.registration.post_message(periodic_wave);
     }
 }
 

src/param.rs

@@ -268,7 +268,7 @@ impl AudioParam {
             panic!("InvalidStateError: automation rate cannot be changed for this param");
         }
 
-        self.registration().post_message(Box::new(value));
+        self.registration().post_message(value);
     }
 
     pub(crate) fn set_automation_rate_constrained(&mut self, value: bool) {
@@ -563,7 +563,7 @@ impl AudioParam {
     }
 
     fn send_event(&self, event: AudioParamEvent) -> &Self {
-        self.registration().post_message(Box::new(event));
+        self.registration().post_message(event);
         self
     }
 }