#7: fix wrong exception handling

Author: amazy

orthanc_api_client/http_client.py

@@ -45,12 +45,12 @@ def get(self, endpoint: str, **kwargs) -> requests.Response:
         try:
             url = self.get_abs_url(endpoint)
             response = self._http_session.get(url, **kwargs)
+
+            self._raise_on_errors(response, url=url)
+            return response
         except requests.RequestException as request_exception:
             self._translate_exception(request_exception, url=url)
 
-        self._raise_on_errors(response, url=url)
-        return response
-
     def get_json(self, endpoint: str, **kwargs) -> Any:
         return self.get(endpoint, **kwargs).json()
 
@@ -61,32 +61,32 @@ def post(self, endpoint: str, **kwargs) -> requests.Response:
         try:
             url = self.get_abs_url(endpoint)
             response = self._http_session.post(url, **kwargs)
+
+            self._raise_on_errors(response, url=url)
+            return response
         except requests.RequestException as request_exception:
             self._translate_exception(request_exception, url=url)
 
-        self._raise_on_errors(response, url=url)
-        return response
-
     def put(self, endpoint: str, **kwargs) -> requests.Response:
         try:
             url = self.get_abs_url(endpoint)
             response = self._http_session.put(url, **kwargs)
+
+            self._raise_on_errors(response, url=url)
+            return response
         except requests.RequestException as request_exception:
             self._translate_exception(request_exception, url=url)
 
-        self._raise_on_errors(response, url=url)
-        return response
-
     def delete(self, endpoint: str, **kwargs) -> requests.Response:
         try:
             url = self.get_abs_url(endpoint)
             response = self._http_session.delete(url, **kwargs)
+
+            self._raise_on_errors(response, url=url)
+            return response
         except requests.RequestException as request_exception:
             self._translate_exception(request_exception, url=url)
 
-        self._raise_on_errors(response, url=url)
-        return response
-
     def close(self):
         self._http_session.close()
 

release-notes.md

@@ -1,3 +1,6 @@
+ 
+- #7: fix wrong exception handling 
+
 v 0.18.4
 ========