Skip to content

Conversation

deepakprabhakara
Copy link
Contributor

@deepakprabhakara deepakprabhakara commented Aug 8, 2025

Related Issue or Design Document

docs for Identity Schema Selection feature

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@deepakprabhakara deepakprabhakara changed the title feature: added first draft for identity schema selection feat: added first draft for identity schema selection Aug 8, 2025
Copy link
Collaborator

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, some minor style comments

next time you can try to add the README to your context or use it to do a final style check with LLM, then we can avoid 90% of the comments 😉


### Registration Example

**Browser flow:**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want a "small" headline you can use h5, no bolding please

GET /self-service/registration/browser?identity_schema=schema-a
```

**API flow:**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above


### Login Example

**Browser flow:**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

Copy link
Contributor

@unatasha8 unatasha8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chore: Copy edits

@piotrmsc piotrmsc merged commit 47af190 into master Aug 20, 2025
9 checks passed
@piotrmsc piotrmsc deleted the feat/multi-schema branch August 20, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants