-
Notifications
You must be signed in to change notification settings - Fork 423
feat: added first draft for identity schema selection #2270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, some minor style comments
next time you can try to add the README to your context or use it to do a final style check with LLM, then we can avoid 90% of the comments 😉
|
||
### Registration Example | ||
|
||
**Browser flow:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want a "small" headline you can use h5, no bolding please
GET /self-service/registration/browser?identity_schema=schema-a | ||
``` | ||
|
||
**API flow:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
|
||
### Login Example | ||
|
||
**Browser flow:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
Core: Copy edits Co-authored-by: Vincent <[email protected]>
Core: Copy edits Co-authored-by: Vincent <[email protected]>
Core: Copy edits Co-authored-by: Vincent <[email protected]>
Core: Copy edits Co-authored-by: Vincent <[email protected]>
Core: Copy edits Co-authored-by: Vincent <[email protected]>
Core: Copy edits Co-authored-by: Vincent <[email protected]>
Core: Copy edits Co-authored-by: Vincent <[email protected]>
Core: Copy edits Co-authored-by: Vincent <[email protected]>
Core: Copy edits Co-authored-by: Vincent <[email protected]>
Core: Copy edits Co-authored-by: Vincent <[email protected]>
Core: Copy edits
Core: Copy edits
Core: Copy edits
Core: Copy edits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chore: Copy edits
Related Issue or Design Document
docs for Identity Schema Selection feature
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments