Resolve issues with error handling (#174)

* errors: do not convert errors compliant with rfcerrors

* handler/oauth2: improve redirect message for insecure http

Author: arekkas

errors.go

@@ -66,6 +66,10 @@ type RFC6749Error struct {
 }
 
 func ErrorToRFC6749Error(err error) *RFC6749Error {
+	if e, ok := err.(*RFC6749Error); ok {
+		return e
+	}
+
 	switch errors.Cause(err) {
 	case ErrInactiveToken:
 		{

glide.lock

@@ -1,34 +1,35 @@
 package: github.com/ory/fosite
 import:
 - package: github.com/asaskevich/govalidator
-  version: ~5.0.0
+  version: ~6.0.0
 - package: github.com/dgrijalva/jwt-go
   version: ~3.0.0
 - package: github.com/golang/mock
   subpackages:
   - gomock
+- package: github.com/oleiade/reflections
+  version: ~1.0.0
 - package: github.com/pborman/uuid
   version: ~1.0.0
 - package: github.com/pkg/errors
   version: ~0.8.0
 - package: github.com/square/go-jose
-  version: ~1.1.0
+  version: ~2.1.1
   subpackages:
   - json
-- package: golang.org/x/crypto
-  subpackages:
-  - bcrypt
-- package: golang.org/x/net
-  subpackages:
-  - context
-testImport:
-- package: github.com/gorilla/mux
-  version: ~1.1.0
 - package: github.com/stretchr/testify
   version: ~1.1.4
   subpackages:
   - assert
   - require
+- package: golang.org/x/crypto
+  subpackages:
+  - bcrypt
+testImport:
+- package: github.com/gorilla/mux
+  version: ~1.4.0
+- package: github.com/parnurzeal/gorequest
+  version: ~0.2.15
 - package: golang.org/x/oauth2
   subpackages:
   - clientcredentials

glide.yaml

@@ -42,7 +42,7 @@ func (c *AuthorizeExplicitGrantHandler) HandleAuthorizeEndpointRequest(ctx conte
 	}
 
 	if !fosite.IsRedirectURISecure(ar.GetRedirectURI()) {
-		return errors.Wrap(fosite.ErrInvalidRequest, "Redirect URL is using an insecure protocol")
+		return errors.Wrap(fosite.ErrInvalidRequest, "Redirect URL is using an insecure protocol, http is only allowed for hosts with suffix `localhost`, for example: http://myapp.localhost/")
 	}
 
 	client := ar.GetClient()