Skip to content

Commit c26a34c

Browse files
shaunnkhanshaunnkhan
committed
chore: test storage provider abstractions
1 parent 7193408 commit c26a34c

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+1631
-432
lines changed

‎access_request_handler_test.go‎

Lines changed: 26 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import (
2222
func TestNewAccessRequest(t *testing.T) {
2323
ctrl := gomock.NewController(t)
2424
store := internal.NewMockStorage(ctrl)
25+
clientManager := internal.NewMockClientManager(ctrl)
2526
handler := internal.NewMockTokenEndpointHandler(ctrl)
2627
handler.EXPECT().CanHandleTokenEndpointRequest(gomock.Any(), gomock.Any()).Return(true).AnyTimes()
2728
handler.EXPECT().CanSkipClientAuth(gomock.Any(), gomock.Any()).Return(false).AnyTimes()
@@ -76,7 +77,8 @@ func TestNewAccessRequest(t *testing.T) {
7677
},
7778
expectErr: ErrInvalidClient,
7879
mock: func() {
79-
store.EXPECT().GetClient(gomock.Any(), gomock.Eq("foo")).Return(nil, errors.New(""))
80+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
81+
clientManager.EXPECT().GetClient(gomock.Any(), gomock.Eq("foo")).Return(nil, errors.New(""))
8082
},
8183
handlers: TokenEndpointHandlers{handler},
8284
},
@@ -101,7 +103,8 @@ func TestNewAccessRequest(t *testing.T) {
101103
},
102104
expectErr: ErrInvalidClient,
103105
mock: func() {
104-
store.EXPECT().GetClient(gomock.Any(), gomock.Eq("foo")).Return(nil, errors.New(""))
106+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
107+
clientManager.EXPECT().GetClient(gomock.Any(), gomock.Eq("foo")).Return(nil, errors.New(""))
105108
},
106109
handlers: TokenEndpointHandlers{handler},
107110
},
@@ -115,7 +118,8 @@ func TestNewAccessRequest(t *testing.T) {
115118
},
116119
expectErr: ErrInvalidClient,
117120
mock: func() {
118-
store.EXPECT().GetClient(gomock.Any(), gomock.Eq("foo")).Return(client, nil)
121+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
122+
clientManager.EXPECT().GetClient(gomock.Any(), gomock.Eq("foo")).Return(client, nil)
119123
client.Public = false
120124
client.Secret = []byte("foo")
121125
hasher.EXPECT().Compare(gomock.Any(), gomock.Eq([]byte("foo")), gomock.Eq([]byte("bar"))).Return(errors.New(""))
@@ -132,7 +136,8 @@ func TestNewAccessRequest(t *testing.T) {
132136
},
133137
expectErr: ErrServerError,
134138
mock: func() {
135-
store.EXPECT().GetClient(gomock.Any(), gomock.Eq("foo")).Return(client, nil)
139+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
140+
clientManager.EXPECT().GetClient(gomock.Any(), gomock.Eq("foo")).Return(client, nil)
136141
client.Public = false
137142
client.Secret = []byte("foo")
138143
hasher.EXPECT().Compare(gomock.Any(), gomock.Eq([]byte("foo")), gomock.Eq([]byte("bar"))).Return(nil)
@@ -149,7 +154,8 @@ func TestNewAccessRequest(t *testing.T) {
149154
"grant_type": {"foo"},
150155
},
151156
mock: func() {
152-
store.EXPECT().GetClient(gomock.Any(), gomock.Eq("foo")).Return(client, nil)
157+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
158+
clientManager.EXPECT().GetClient(gomock.Any(), gomock.Eq("foo")).Return(client, nil)
153159
client.Public = false
154160
client.Secret = []byte("foo")
155161
hasher.EXPECT().Compare(gomock.Any(), gomock.Eq([]byte("foo")), gomock.Eq([]byte("bar"))).Return(nil)
@@ -172,7 +178,8 @@ func TestNewAccessRequest(t *testing.T) {
172178
"grant_type": {"foo"},
173179
},
174180
mock: func() {
175-
store.EXPECT().GetClient(gomock.Any(), gomock.Eq("foo")).Return(client, nil)
181+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
182+
clientManager.EXPECT().GetClient(gomock.Any(), gomock.Eq("foo")).Return(client, nil)
176183
client.Public = true
177184
handler.EXPECT().HandleTokenEndpointRequest(gomock.Any(), gomock.Any()).Return(nil)
178185
},
@@ -211,6 +218,7 @@ func TestNewAccessRequest(t *testing.T) {
211218
func TestNewAccessRequestWithoutClientAuth(t *testing.T) {
212219
ctrl := gomock.NewController(t)
213220
store := internal.NewMockStorage(ctrl)
221+
clientManager := internal.NewMockClientManager(ctrl)
214222
handler := internal.NewMockTokenEndpointHandler(ctrl)
215223
handler.EXPECT().CanHandleTokenEndpointRequest(gomock.Any(), gomock.Any()).Return(true).AnyTimes()
216224
handler.EXPECT().CanSkipClientAuth(gomock.Any(), gomock.Any()).Return(true).AnyTimes()
@@ -234,7 +242,7 @@ func TestNewAccessRequestWithoutClientAuth(t *testing.T) {
234242
{
235243
form: url.Values{},
236244
mock: func() {
237-
store.EXPECT().GetClient(gomock.Any(), gomock.Any()).Times(0)
245+
clientManager.EXPECT().GetClient(gomock.Any(), gomock.Any()).Times(0)
238246
},
239247
method: "POST",
240248
expectErr: ErrInvalidRequest,
@@ -245,7 +253,7 @@ func TestNewAccessRequestWithoutClientAuth(t *testing.T) {
245253
"grant_type": {"foo"},
246254
},
247255
mock: func() {
248-
store.EXPECT().GetClient(gomock.Any(), gomock.Any()).Times(0)
256+
clientManager.EXPECT().GetClient(gomock.Any(), gomock.Any()).Times(0)
249257
},
250258
method: "POST",
251259
expectErr: ErrInvalidRequest,
@@ -261,7 +269,8 @@ func TestNewAccessRequestWithoutClientAuth(t *testing.T) {
261269
},
262270
mock: func() {
263271
// despite error from storage, we should success, because client auth is not required
264-
store.EXPECT().GetClient(gomock.Any(), "foo").Return(nil, errors.New("no client")).Times(1)
272+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
273+
clientManager.EXPECT().GetClient(gomock.Any(), "foo").Return(nil, errors.New("no client")).Times(1)
265274
handler.EXPECT().HandleTokenEndpointRequest(gomock.Any(), gomock.Any()).Return(nil)
266275
},
267276
method: "POST",
@@ -299,7 +308,8 @@ func TestNewAccessRequestWithoutClientAuth(t *testing.T) {
299308
"grant_type": {"foo"},
300309
},
301310
mock: func() {
302-
store.EXPECT().GetClient(gomock.Any(), "foo").Return(anotherClient, nil).Times(1)
311+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
312+
clientManager.EXPECT().GetClient(gomock.Any(), "foo").Return(anotherClient, nil).Times(1)
303313
hasher.EXPECT().Compare(gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).Times(1)
304314
handler.EXPECT().HandleTokenEndpointRequest(gomock.Any(), gomock.Any()).Return(nil)
305315
},
@@ -340,6 +350,7 @@ func TestNewAccessRequestWithoutClientAuth(t *testing.T) {
340350
func TestNewAccessRequestWithMixedClientAuth(t *testing.T) {
341351
ctrl := gomock.NewController(t)
342352
store := internal.NewMockStorage(ctrl)
353+
clientManager := internal.NewMockClientManager(ctrl)
343354

344355
handlerWithClientAuth := internal.NewMockTokenEndpointHandler(ctrl)
345356
handlerWithClientAuth.EXPECT().CanHandleTokenEndpointRequest(gomock.Any(), gomock.Any()).Return(true).AnyTimes()
@@ -372,7 +383,8 @@ func TestNewAccessRequestWithMixedClientAuth(t *testing.T) {
372383
"grant_type": {"foo"},
373384
},
374385
mock: func() {
375-
store.EXPECT().GetClient(gomock.Any(), gomock.Eq("foo")).Return(client, nil)
386+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
387+
clientManager.EXPECT().GetClient(gomock.Any(), gomock.Eq("foo")).Return(client, nil)
376388
client.Public = false
377389
client.Secret = []byte("foo")
378390
hasher.EXPECT().Compare(gomock.Any(), gomock.Eq([]byte("foo")), gomock.Eq([]byte("bar"))).Return(errors.New("hash err"))
@@ -390,7 +402,8 @@ func TestNewAccessRequestWithMixedClientAuth(t *testing.T) {
390402
"grant_type": {"foo"},
391403
},
392404
mock: func() {
393-
store.EXPECT().GetClient(gomock.Any(), gomock.Eq("foo")).Return(client, nil)
405+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
406+
clientManager.EXPECT().GetClient(gomock.Any(), gomock.Eq("foo")).Return(client, nil)
394407
client.Public = false
395408
client.Secret = []byte("foo")
396409
hasher.EXPECT().Compare(gomock.Any(), gomock.Eq([]byte("foo")), gomock.Eq([]byte("bar"))).Return(nil)
@@ -412,7 +425,7 @@ func TestNewAccessRequestWithMixedClientAuth(t *testing.T) {
412425
"grant_type": {"foo"},
413426
},
414427
mock: func() {
415-
store.EXPECT().GetClient(gomock.Any(), gomock.Any()).Times(0)
428+
clientManager.EXPECT().GetClient(gomock.Any(), gomock.Any()).Times(0)
416429
handlerWithoutClientAuth.EXPECT().HandleTokenEndpointRequest(gomock.Any(), gomock.Any()).Return(nil)
417430
},
418431
method: "POST",

‎authorize_request_handler_test.go‎

Lines changed: 44 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import (
2727
// values in which the order of values does not matter.
2828
func TestNewAuthorizeRequest(t *testing.T) {
2929
var store *MockStorage
30+
var clientManager *MockClientManager
3031

3132
redir, _ := url.Parse("https://foo.bar/cb")
3233
specialCharRedir, _ := url.Parse("web+application://callback")
@@ -46,7 +47,8 @@ func TestNewAuthorizeRequest(t *testing.T) {
4647
r: &http.Request{},
4748
expectedError: ErrInvalidClient,
4849
mock: func() {
49-
store.EXPECT().GetClient(gomock.Any(), gomock.Any()).Return(nil, errors.New("foo"))
50+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
51+
clientManager.EXPECT().GetClient(gomock.Any(), gomock.Any()).Return(nil, errors.New("foo"))
5052
},
5153
},
5254
/* invalid redirect uri */
@@ -56,7 +58,8 @@ func TestNewAuthorizeRequest(t *testing.T) {
5658
query: url.Values{"redirect_uri": []string{"invalid"}},
5759
expectedError: ErrInvalidClient,
5860
mock: func() {
59-
store.EXPECT().GetClient(gomock.Any(), gomock.Any()).Return(nil, errors.New("foo"))
61+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
62+
clientManager.EXPECT().GetClient(gomock.Any(), gomock.Any()).Return(nil, errors.New("foo"))
6063
},
6164
},
6265
/* invalid client */
@@ -66,7 +69,8 @@ func TestNewAuthorizeRequest(t *testing.T) {
6669
query: url.Values{"redirect_uri": []string{"https://foo.bar/cb"}},
6770
expectedError: ErrInvalidClient,
6871
mock: func() {
69-
store.EXPECT().GetClient(gomock.Any(), gomock.Any()).Return(nil, errors.New("foo"))
72+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
73+
clientManager.EXPECT().GetClient(gomock.Any(), gomock.Any()).Return(nil, errors.New("foo"))
7074
},
7175
},
7276
/* redirect client mismatch */
@@ -78,7 +82,8 @@ func TestNewAuthorizeRequest(t *testing.T) {
7882
},
7983
expectedError: ErrInvalidRequest,
8084
mock: func() {
81-
store.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{RedirectURIs: []string{"invalid"}, Scopes: []string{}}, nil)
85+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
86+
clientManager.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{RedirectURIs: []string{"invalid"}, Scopes: []string{}}, nil)
8287
},
8388
},
8489
/* redirect client mismatch */
@@ -91,7 +96,8 @@ func TestNewAuthorizeRequest(t *testing.T) {
9196
},
9297
expectedError: ErrInvalidRequest,
9398
mock: func() {
94-
store.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{RedirectURIs: []string{"invalid"}, Scopes: []string{}}, nil)
99+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
100+
clientManager.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{RedirectURIs: []string{"invalid"}, Scopes: []string{}}, nil)
95101
},
96102
},
97103
/* redirect client mismatch */
@@ -104,7 +110,8 @@ func TestNewAuthorizeRequest(t *testing.T) {
104110
},
105111
expectedError: ErrInvalidRequest,
106112
mock: func() {
107-
store.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{RedirectURIs: []string{"invalid"}, Scopes: []string{}}, nil)
113+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
114+
clientManager.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{RedirectURIs: []string{"invalid"}, Scopes: []string{}}, nil)
108115
},
109116
},
110117
/* no state */
@@ -118,7 +125,8 @@ func TestNewAuthorizeRequest(t *testing.T) {
118125
},
119126
expectedError: ErrInvalidState,
120127
mock: func() {
121-
store.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{RedirectURIs: []string{"https://foo.bar/cb"}, Scopes: []string{}}, nil)
128+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
129+
clientManager.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{RedirectURIs: []string{"https://foo.bar/cb"}, Scopes: []string{}}, nil)
122130
},
123131
},
124132
/* short state */
@@ -133,7 +141,8 @@ func TestNewAuthorizeRequest(t *testing.T) {
133141
},
134142
expectedError: ErrInvalidState,
135143
mock: func() {
136-
store.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{RedirectURIs: []string{"https://foo.bar/cb"}, Scopes: []string{}}, nil)
144+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
145+
clientManager.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{RedirectURIs: []string{"https://foo.bar/cb"}, Scopes: []string{}}, nil)
137146
},
138147
},
139148
/* fails because scope not given */
@@ -148,7 +157,8 @@ func TestNewAuthorizeRequest(t *testing.T) {
148157
"scope": {"foo bar baz"},
149158
},
150159
mock: func() {
151-
store.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{RedirectURIs: []string{"https://foo.bar/cb"}, Scopes: []string{"foo", "bar"}}, nil)
160+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
161+
clientManager.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{RedirectURIs: []string{"https://foo.bar/cb"}, Scopes: []string{"foo", "bar"}}, nil)
152162
},
153163
expectedError: ErrInvalidScope,
154164
},
@@ -165,7 +175,8 @@ func TestNewAuthorizeRequest(t *testing.T) {
165175
"audience": {"https://cloud.ory.sh/api https://www.ory.sh/api"},
166176
},
167177
mock: func() {
168-
store.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{
178+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
179+
clientManager.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{
169180
RedirectURIs: []string{"https://foo.bar/cb"}, Scopes: []string{"foo", "bar"},
170181
Audience: []string{"https://cloud.ory.sh/api"},
171182
}, nil)
@@ -185,7 +196,8 @@ func TestNewAuthorizeRequest(t *testing.T) {
185196
"audience": {"https://cloud.ory.sh/api https://www.ory.sh/api"},
186197
},
187198
mock: func() {
188-
store.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{
199+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
200+
clientManager.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{
189201
ResponseTypes: []string{"code token"},
190202
RedirectURIs: []string{"https://foo.bar/cb"},
191203
Scopes: []string{"foo", "bar"},
@@ -220,7 +232,8 @@ func TestNewAuthorizeRequest(t *testing.T) {
220232
"audience": {"https://cloud.ory.sh/api", "https://www.ory.sh/api"},
221233
},
222234
mock: func() {
223-
store.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{
235+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
236+
clientManager.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{
224237
ResponseTypes: []string{"code token"},
225238
RedirectURIs: []string{"https://foo.bar/cb"},
226239
Scopes: []string{"foo", "bar"},
@@ -255,7 +268,8 @@ func TestNewAuthorizeRequest(t *testing.T) {
255268
"audience": {"test value", ""},
256269
},
257270
mock: func() {
258-
store.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{
271+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
272+
clientManager.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{
259273
ResponseTypes: []string{"code token"},
260274
RedirectURIs: []string{"https://foo.bar/cb"},
261275
Scopes: []string{"foo", "bar"},
@@ -290,7 +304,8 @@ func TestNewAuthorizeRequest(t *testing.T) {
290304
"audience": {"https://cloud.ory.sh/api https://www.ory.sh/api"},
291305
},
292306
mock: func() {
293-
store.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{
307+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
308+
clientManager.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{
294309
ResponseTypes: []string{"code token"},
295310
RedirectURIs: []string{"web+application://callback"},
296311
Scopes: []string{"foo", "bar"},
@@ -325,7 +340,8 @@ func TestNewAuthorizeRequest(t *testing.T) {
325340
"audience": {"https://cloud.ory.sh/api https://www.ory.sh/api"},
326341
},
327342
mock: func() {
328-
store.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{
343+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
344+
clientManager.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{
329345
ResponseTypes: []string{"code token"},
330346
RedirectURIs: []string{"https://foo.bar/cb"},
331347
Scopes: []string{"foo", "bar"},
@@ -360,7 +376,8 @@ func TestNewAuthorizeRequest(t *testing.T) {
360376
"response_mode": {"unknown"},
361377
},
362378
mock: func() {
363-
store.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{RedirectURIs: []string{"https://foo.bar/cb"}, Scopes: []string{"foo", "bar"}, ResponseTypes: []string{"code token"}}, nil)
379+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
380+
clientManager.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{RedirectURIs: []string{"https://foo.bar/cb"}, Scopes: []string{"foo", "bar"}, ResponseTypes: []string{"code token"}}, nil)
364381
},
365382
expectedError: ErrUnsupportedResponseMode,
366383
},
@@ -377,7 +394,8 @@ func TestNewAuthorizeRequest(t *testing.T) {
377394
"response_mode": {"form_post"},
378395
},
379396
mock: func() {
380-
store.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{RedirectURIs: []string{"https://foo.bar/cb"}, Scopes: []string{"foo", "bar"}, ResponseTypes: []string{"code token"}}, nil)
397+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
398+
clientManager.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultClient{RedirectURIs: []string{"https://foo.bar/cb"}, Scopes: []string{"foo", "bar"}, ResponseTypes: []string{"code token"}}, nil)
381399
},
382400
expectedError: ErrUnsupportedResponseMode,
383401
},
@@ -394,7 +412,8 @@ func TestNewAuthorizeRequest(t *testing.T) {
394412
"response_mode": {"form_post"},
395413
},
396414
mock: func() {
397-
store.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultResponseModeClient{
415+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
416+
clientManager.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultResponseModeClient{
398417
DefaultClient: &DefaultClient{
399418
RedirectURIs: []string{"https://foo.bar/cb"},
400419
Scopes: []string{"foo", "bar"},
@@ -419,7 +438,8 @@ func TestNewAuthorizeRequest(t *testing.T) {
419438
"audience": {"https://cloud.ory.sh/api https://www.ory.sh/api"},
420439
},
421440
mock: func() {
422-
store.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultResponseModeClient{
441+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
442+
clientManager.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultResponseModeClient{
423443
DefaultClient: &DefaultClient{
424444
RedirectURIs: []string{"https://foo.bar/cb"},
425445
Scopes: []string{"foo", "bar"},
@@ -461,7 +481,8 @@ func TestNewAuthorizeRequest(t *testing.T) {
461481
"audience": {"https://cloud.ory.sh/api https://www.ory.sh/api"},
462482
},
463483
mock: func() {
464-
store.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultResponseModeClient{
484+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
485+
clientManager.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultResponseModeClient{
465486
DefaultClient: &DefaultClient{
466487
RedirectURIs: []string{"https://foo.bar/cb"},
467488
Scopes: []string{"foo", "bar"},
@@ -503,7 +524,8 @@ func TestNewAuthorizeRequest(t *testing.T) {
503524
"audience": {"https://cloud.ory.sh/api https://www.ory.sh/api"},
504525
},
505526
mock: func() {
506-
store.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultResponseModeClient{
527+
store.EXPECT().ClientManager().Return(clientManager).Times(1)
528+
clientManager.EXPECT().GetClient(gomock.Any(), "1234").Return(&DefaultResponseModeClient{
507529
DefaultClient: &DefaultClient{
508530
RedirectURIs: []string{"https://foo.bar/cb"},
509531
Scopes: []string{"foo", "bar"},
@@ -536,6 +558,7 @@ func TestNewAuthorizeRequest(t *testing.T) {
536558
t.Run(fmt.Sprintf("case=%d", k), func(t *testing.T) {
537559
ctrl := gomock.NewController(t)
538560
store = NewMockStorage(ctrl)
561+
clientManager = NewMockClientManager(ctrl)
539562
defer ctrl.Finish()
540563

541564
c.mock()

0 commit comments

Comments
 (0)