NewDefaultSession's SetSubject should set IDTokenClaims as well

[mitar]

Preflight checklist

• I could not find a solution in the existing issues, docs, nor discussions.
• I agree to follow this project's Code of Conduct.
• I have read and am following this repository's Contribution Guidelines.
• I have joined the Ory Community Slack.
• I am signed up to the Ory Security Patch Newsletter.

Ory Network Project

No response

Describe your problem

openid.Session requires subject to be set. openid.NewDefaultSession() returns an openid.DefaultSession without subject set. It provides SetSubject to set the subject, but calling it still does not make the session have subject. It has to be set in IDTokenClaims as well.

Describe your ideal solution

		session := openid.NewDefaultSession()
		session.SetSubject(subject)

Should be enough.

Workarounds or alternatives

One currently has to set it manually:

		session := openid.NewDefaultSession()
		session.SetSubject(subject)
		session.IDTokenClaims().Subject = subject

Version

v0.46.1-0.20240213123944-f38352921f22

Additional Context

No response

[github-actions]

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

• open a PR referencing and resolving the issue;
• leave a comment on it and discuss ideas on how you could contribute towards resolving it;
• leave a comment and describe in detail why this issue is critical for your use case;
• open a new issue with updated details and a plan for resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

[mitar]

Unstale.

[mitar]

So should the above be added in PR to fosite?

[aeneasr]

Honestly, the session code is really messy right now. We'll probably spend some time in the near future removing complexity/confusion and simplifying code. Thus, I don't think it makes sense to address this issue specifically as it will require work to make it behave correctly in Hydra.

Instead, we'll probably fix the architecture here.