fix: change WithDetail to deep copy details map (#140)

Author: jonas-jonas

error_default.go

@@ -7,6 +7,7 @@ import (
 	stderr "errors"
 	"fmt"
 	"io"
+	"maps"
 	"net/http"
 
 	"github.com/pkg/errors"
@@ -289,6 +290,8 @@ func (e DefaultError) WithDebug(debug string) *DefaultError {
 func (e DefaultError) WithDetail(key string, detail interface{}) *DefaultError {
 	if e.DetailsField == nil {
 		e.DetailsField = map[string]interface{}{}
+	} else {
+		e.DetailsField = maps.Clone(e.DetailsField)
 	}
 	e.DetailsField[key] = detail
 	return &e
@@ -297,6 +300,8 @@ func (e DefaultError) WithDetail(key string, detail interface{}) *DefaultError {
 func (e DefaultError) WithDetailf(key string, message string, args ...interface{}) *DefaultError {
 	if e.DetailsField == nil {
 		e.DetailsField = map[string]interface{}{}
+	} else {
+		e.DetailsField = maps.Clone(e.DetailsField)
 	}
 	e.DetailsField[key] = fmt.Sprintf(message, args...)
 	return &e

error_default_test.go

@@ -67,6 +67,15 @@ func TestToDefaultError(t *testing.T) {
 		assert.EqualValues(t, map[string]interface{}{"foo-debug": "bar"}, ToDefaultError(e, "").Details())
 	})
 
+	t.Run("case=details copies map", func(t *testing.T) {
+		eBar := DefaultError{}.WithDetail("foo", "bar")
+		eBaz := eBar.WithDetail("foo", "baz")
+		eBazBar := eBaz.WithDetailf("bar", "baz%s", "bar")
+		assert.EqualValues(t, map[string]interface{}{"foo": "bar"}, ToDefaultError(eBar, "").Details())
+		assert.EqualValues(t, map[string]interface{}{"foo": "baz"}, ToDefaultError(eBaz, "").Details())
+		assert.EqualValues(t, map[string]interface{}{"foo": "baz", "bar": "bazbar"}, ToDefaultError(eBazBar, "").Details())
+	})
+
 	t.Run("case=rid", func(t *testing.T) {
 		e := &DefaultError{
 			RIDField: "foo-rid",