Skip to content

Commit da16aef

Browse files
committed
Adding documentation update
1 parent 23ef6a2 commit da16aef

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

.githooks/pre-commit

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,12 @@ if [ -x ".bin/golangci-lint" ]; then
2626
elif command -v golangci-lint &> /dev/null; then
2727
golangci-lint run
2828
else
29-
echo "Warning: golangci-lint not found, skipping. Install with: make deps"
29+
GOPATH_BIN="$(go env GOPATH 2>/dev/null)/bin/golangci-lint"
30+
if [ -n "$GOPATH_BIN" ] && [ -x "$GOPATH_BIN" ]; then
31+
"$GOPATH_BIN" run
32+
else
33+
echo "Warning: golangci-lint not found, skipping. Install with: make deps"
34+
fi
3035
fi
3136

3237
# Build check

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ Unit tests can be run without any credentials:
4545

4646
```bash
4747
make test # Run all unit tests with coverage
48-
make test-short # Run unit tests in short mode (this is what CI runs)
48+
make test-short # Run unit tests in short mode (CI runs these with coverage enabled)
4949
```
5050

5151
### Acceptance Tests
@@ -102,7 +102,7 @@ Some tests require specific Ory plan features. Enable them with environment vari
102102
| `ORY_PROJECT_TESTS_ENABLED=true` | Run project creation/deletion tests |
103103
| `ORY_EVENT_STREAM_TESTS_ENABLED=true` | Run event stream tests (requires Enterprise plan + AWS setup below) |
104104

105-
> **Note:** CI enables **all** feature flags on pull requests. `make test-acc-all` enables all flags except `ORY_PROJECT_TESTS_ENABLED` (project creation/deletion tests are excluded because they are slow and potentially destructive). To run those locally, set `ORY_PROJECT_TESTS_ENABLED=true` explicitly.
105+
> **Note:** CI enables **all** feature flags, including `ORY_PROJECT_TESTS_ENABLED`, on pull requests. Locally, `make test-acc-all` enables all flags **except** `ORY_PROJECT_TESTS_ENABLED` by default (project creation/deletion tests are excluded because they are slow and potentially destructive). To run those locally, set `ORY_PROJECT_TESTS_ENABLED=true` explicitly.
106106
107107
#### Event Stream Tests
108108

0 commit comments

Comments
 (0)