Commit efdaaab
committed
Ensure correct value from/to SERIALCONSOLE
1.For OSD workers, some machines use ttyS0 and some others use ttyS1 or even ttyS2
which is assigned to setting SERIALDEV. But SERIALDEV is not safe enough to be used
everywhere, because it becomes sshserial during test run, here is an example:
https://openqa.suse.de/tests/21287146/file/vars.json.
2.Merge request https://gitlab.suse.de/openqa/salt-pillars-openqa/-/merge_requests/1225
introduces setting SERIALCONSOLE which is already being widely used in automation code.
This can avoid incorrect SERIALCONSOLE leading to test run failure, for exmaple:
https://openqa.suse.de/tests/21287262#step/prepare_transactional_server/74.
3.Current subroutine save_serial_console resets SERIALCONSOLE, if it has no value, to
default value obtained from SERIALDEV which may become sshserial. So it is necessary to
check and assign more meaningful default value ttyS1 to SERIALCONSOLE.1 parent 63a1945 commit efdaaab
1 file changed
+1
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| 67 | + | |
67 | 68 | | |
68 | 69 | | |
69 | 70 | | |
| |||
0 commit comments