Skip to content

Commit 7311031

Browse files
Fix: Variable case in test action (#807)
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
1 parent 74a4115 commit 7311031

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

.github/actions/python-test-action/action.yaml

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -41,16 +41,17 @@ runs:
4141
shell: bash
4242
run: |
4343
# Setup action/environment
44+
set -vx
4445
if [ -z "${{ inputs.python_version }}" ]; then
4546
echo "Error: Python version was not provided ❌"
4647
exit 1
4748
else
4849
echo "Using Python: ${{ inputs.python_version }} 🐍"
4950
fi
5051
51-
PATH_PREFIX="${{ inputs.path_prefix }}"
52-
if [ -n "$PATH_PREFIX" ] && \
53-
[ ! -d "$PATH_PREFIX" ]; then
52+
path_prefix="${{ inputs.path_prefix }}"
53+
if [ -n "$path_prefix" ] && \
54+
[ ! -d "$path_prefix" ]; then
5455
echo "Error: invalid path/prefix to project directory ❌"
5556
exit 1
5657
fi
@@ -60,9 +61,9 @@ runs:
6061
echo "${{ inputs.path_prefix }}${{ inputs.tests_path }}"
6162
exit 1
6263
fi
63-
PERMIT_FAIL=$(echo "${{ inputs.PERMIT_FAIL }}" |\
64+
permit_fail=$(echo "${{ inputs.permit_fail }}" |\
6465
tr '[:upper:]' '[:lower:]')
65-
if [ "f$PERMIT_FAIL" = "ftrue" ]; then
66+
if [ "f$permit_fail" = "ftrue" ]; then
6667
echo "permit_fail=true" >> "$GITHUB_ENV"
6768
fi
6869
@@ -73,11 +74,11 @@ runs:
7374
echo "Installing project and dependencies"
7475
# Note: quirks with pip install need careful handling
7576
76-
if [ -f "$PATH_PREFIXpyproject.toml" ]; then
77-
echo "Source: ${PATH_PREFIX%/} ⬇️"
78-
echo echo ${@%/}
79-
pip install -q ${PATH_PREFIX%/}
80-
elif [ -z "$PATH_PREFIX" ] && \
77+
78+
if [ -f "$path_prefixpyproject.toml" ]; then
79+
echo "Source: ${path_prefix%/} ⬇️"
80+
pip install -q ${path_prefix%/}
81+
elif [ -z "$path_prefix" ] && \
8182
[ -f pyproject.toml ]; then
8283
echo "Source: pyproject.toml ⬇️"
8384
pip install -q .
@@ -129,9 +130,9 @@ runs:
129130
shell: bash
130131
run: |
131132
# Create ZIP archive of coverage report
132-
REPORT_ARTEFACT=$(echo ${{ inputs.REPORT_ARTEFACT }} |\
133+
report_artefact=$(echo ${{ inputs.report_artefact }} |\
133134
tr '[:upper:]' '[:lower:]')
134-
if [ "f$REPORT_ARTEFACT" = "ftrue" ]; then
135+
if [ "f$report_artefact" = "ftrue" ]; then
135136
if [ -d coverage_report ]; then
136137
echo "Creating ZIP file of HTML coverage report"
137138
zip -r test_coverage_report-${{ inputs.python_version }}.zip \
@@ -140,7 +141,7 @@ runs:
140141
echo "No coverage report directory exists"
141142
fi
142143
fi
143-
echo "report_artefact=$REPORT_ARTEFACT" >> "$GITHUB_ENV"
144+
echo "report_artefact=$report_artefact" >> "$GITHUB_ENV"
144145
145146
- name: "Upload test/coverage report"
146147
# yamllint disable-line rule:line-length

0 commit comments

Comments
 (0)