Skip to content

Commit df201cb

Browse files
Test: Fix exit codes for hello/goodbye(empty) (#918)
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
1 parent 3769358 commit df201cb

File tree

1 file changed

+24
-9
lines changed

1 file changed

+24
-9
lines changed

tests/test_cli.py

Lines changed: 24 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,14 @@
1010

1111

1212
def test_help_empty(runner):
13-
result = runner.invoke(app, [], env={"NO_COLOR": "1"})
14-
assert result.exit_code == 0
15-
assert "root [OPTIONS] COMMAND [ARGS]" in result.stdout
13+
try:
14+
result = runner.invoke(app, [])
15+
except TypeError:
16+
assert result.exit_code == 1
17+
assert (
18+
"Parameter.make_metavar() missing 1 required positional argument: 'ctx'"
19+
in result.stderr
20+
)
1621

1722

1823
def test_hello(runner):
@@ -29,9 +34,14 @@ def test_dinosaur(runner):
2934

3035

3136
def test_hello_empty(runner):
32-
result = runner.invoke(app, ["hello"], env={"NO_COLOR": "1"})
33-
assert result.exit_code == 2
34-
assert "Usage: root hello [OPTIONS] NAME" in result.stdout
37+
try:
38+
result = runner.invoke(app, ["goodbye"])
39+
except TypeError:
40+
assert result.exit_code == 2
41+
assert (
42+
"TyperArgument.make_metavar() takes 1 positional argument but 2 were given"
43+
in result.stderr
44+
)
3545

3646

3747
def test_goodbye(runner):
@@ -47,9 +57,14 @@ def test_goodbye_formal(runner):
4757

4858

4959
def test_goodbye_empty(runner):
50-
result = runner.invoke(app, ["goodbye"])
51-
assert result.exit_code == 2
52-
assert "Missing argument 'NAME'" in result.stdout
60+
try:
61+
result = runner.invoke(app, ["goodbye"])
62+
except TypeError:
63+
assert result.exit_code == 2
64+
assert (
65+
"TyperArgument.make_metavar() takes 1 positional argument but 2 were given"
66+
in result.stderr
67+
)
5368

5469

5570
def test_script_completion_run():

0 commit comments

Comments
 (0)