Skip to content

Commit f32a511

Browse files
Test: Fix exit codes for hello/goodbye(empty)
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
1 parent 3769358 commit f32a511

File tree

1 file changed

+17
-8
lines changed

1 file changed

+17
-8
lines changed

tests/test_cli.py

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@
1010

1111

1212
def test_help_empty(runner):
13-
result = runner.invoke(app, [], env={"NO_COLOR": "1"})
13+
result = runner.invoke(app, [])
1414
assert result.exit_code == 0
15-
assert "root [OPTIONS] COMMAND [ARGS]" in result.stdout
1615

1716

1817
def test_hello(runner):
@@ -29,9 +28,14 @@ def test_dinosaur(runner):
2928

3029

3130
def test_hello_empty(runner):
32-
result = runner.invoke(app, ["hello"], env={"NO_COLOR": "1"})
33-
assert result.exit_code == 2
34-
assert "Usage: root hello [OPTIONS] NAME" in result.stdout
31+
try:
32+
result = runner.invoke(app, ["goodbye"])
33+
except TypeError:
34+
assert result.exit_code == 2
35+
assert (
36+
"TyperArgument.make_metavar() takes 1 positional argument but 2 were given"
37+
in result.stderr
38+
)
3539

3640

3741
def test_goodbye(runner):
@@ -47,9 +51,14 @@ def test_goodbye_formal(runner):
4751

4852

4953
def test_goodbye_empty(runner):
50-
result = runner.invoke(app, ["goodbye"])
51-
assert result.exit_code == 2
52-
assert "Missing argument 'NAME'" in result.stdout
54+
try:
55+
result = runner.invoke(app, ["goodbye"])
56+
except TypeError:
57+
assert result.exit_code == 2
58+
assert (
59+
"TyperArgument.make_metavar() takes 1 positional argument but 2 were given"
60+
in result.stderr
61+
)
5362

5463

5564
def test_script_completion_run():

0 commit comments

Comments
 (0)