Skip to content

Conversation

@shivaahir158
Copy link
Collaborator

@shivaahir158 shivaahir158 commented Nov 18, 2024

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details -

  1. Adding Playwright tests on CI, after manually copying the 'etc' folder from the Raptor repo.
  2. Tests run fine, and have removed acpu.test.js, after having a thorough discussion on the acpu block not being enabled for this device.xml file.

What is currently done? (Provide issue link if applicable)

What does this pull request change?

Which part of the code base require a change

  • Frontend:
  • Backend:
  • Library: <Specify the library name, e.g. npm packages>
  • Plug-in: <Specify the plugin name, e.g. Webpack, jtest>
  • Documentation
  • Regression tests: tests/e2e
  • Continuous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break backward-compatibility. If so, please list who may be influenced.

@shivaahir158 shivaahir158 changed the title playwright on CI Running playwright tests on CI Nov 18, 2024
@codecov
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.83%. Comparing base (df62be2) to head (cf7e5ca).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #267   +/-   ##
=======================================
  Coverage   68.83%   68.83%           
=======================================
  Files         110      110           
  Lines        9022     9022           
  Branches      402      402           
=======================================
  Hits         6210     6210           
  Misses       2812     2812           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@shivaahir158 shivaahir158 marked this pull request as ready for review November 18, 2024 19:13
@shivaahir158 shivaahir158 self-assigned this Nov 18, 2024
@shivaahir158 shivaahir158 merged commit 94140f9 into main Nov 18, 2024
11 checks passed
@shivaahir158 shivaahir158 deleted the playwright-CI branch November 18, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants