2321: Added max-warnings to check coding standards

Author: tuj

package.json

@@ -48,9 +48,9 @@
     "vite": "^5.2.11"
   },
   "scripts": {
-    "lint:js": "eslint --ext .js --ext .jsx ./src",
+    "lint:js": "eslint --ext .js --ext .jsx ./src --max-warnings=0",
     "lint:js:fix": "eslint --ext .js --ext .jsx --fix ./src",
-    "lint:scss": "stylelint \"./src/**/*.scss\"",
+    "lint:scss": "stylelint \"./src/**/*.scss\" --max-warnings=0",
     "lint:scss:fix": "stylelint --fix \"./src/**/*.scss\"",
     "check-coding-standards": "yarn lint:js && yarn lint:scss",
     "apply-coding-standards": "yarn lint:js:fix && yarn lint:scss:fix",

src/components/feed-sources/templates/calendar-api-feed-type.jsx

@@ -1,8 +1,8 @@
 import { React, useEffect, useState } from "react";
 import PropTypes from "prop-types";
 import { useTranslation } from "react-i18next";
-import MultiselectFromEndpoint from "../../slide/content/multiselect-from-endpoint";
 import { Alert } from "react-bootstrap";
+import MultiselectFromEndpoint from "../../slide/content/multiselect-from-endpoint";
 import ConfigLoader from "../../../config-loader";
 
 const CalendarApiFeedType = ({

src/components/slide/content/poster-selector.jsx

@@ -338,6 +338,7 @@ function PosterSelector({
     setSingleSelectedOccurrence(null);
   };
 
+  /* eslint-disable jsx-a11y/control-has-associated-label */
   return (
     <Card className="mb-3">
       <Card.Body>
@@ -886,6 +887,7 @@ function PosterSelector({
       </Card.Body>
     </Card>
   );
+  /* eslint-enable jsx-a11y/control-has-associated-label */
 }
 
 PosterSelector.propTypes = {

src/components/slide/content/station/station-selector.jsx

@@ -48,10 +48,11 @@ function StationSelector({
   const onFilter = (filter) => {
     setSearchText(filter);
   };
+
   /**
-   * Map the data recieved from the midttrafik api.
+   * Map the data received from the midttrafik api.
    *
-   * @param {object} locationData
+   * @param {Array} locationData The input location data.
    * @returns {Array} The mapped data.
    */
   const mapLocationData = (locationData) => {
@@ -63,6 +64,7 @@ function StationSelector({
 
   useEffect(() => {
     if (!config?.rejseplanenApiKey) {
+      // eslint-disable-next-line no-console
       console.error("rejseplanenApiKey not set.");
       return;
     }

src/components/util/date-value.jsx

@@ -1,4 +1,3 @@
-import { React } from "react";
 import PropTypes from "prop-types";
 import dayjs from "dayjs";
 

src/components/util/drag-and-drop-table/drag-and-drop-table.jsx

@@ -106,6 +106,7 @@ function DragAndDropTable({
   });
 
   /* eslint-disable react/jsx-props-no-spreading */
+  /* eslint-disable jsx-a11y/control-has-associated-label  */
   return (
     <div className="table-responsive">
       <Table id="drag-and-drop-table">
@@ -168,6 +169,8 @@ function DragAndDropTable({
       <small id="aria-label-for-drag-and-drop">{t("help-text")}</small>
     </div>
   );
+  /* eslint-enable react/jsx-props-no-spreading  */
+  /* eslint-enable jsx-a11y/control-has-associated-label  */
 }
 
 DragAndDropTable.propTypes = {

src/components/util/forms/checkbox-options.jsx

@@ -1,10 +1,12 @@
 import { React } from "react";
+import PropTypes from "prop-types";
 
 /**
- * @param root0
- * @param root0.formData
- * @param root0.data
- * @param root0.onChange
+ * @param {object} props The props.
+ * @param {object} props.formData The form data.
+ * @param {object} props.data The data.
+ * @param {Function} props.onChange On change callback.
+ * @returns {React.JSX} The component.
  */
 function CheckboxOptions({ formData, data, onChange }) {
   const values = data[formData.name] ?? [];
@@ -47,4 +49,19 @@ function CheckboxOptions({ formData, data, onChange }) {
   );
 }
 
+CheckboxOptions.propTypes = {
+  formData: PropTypes.shape({
+    name: PropTypes.string,
+    formGroupClasses: PropTypes.string,
+    options: PropTypes.arrayOf(
+      PropTypes.shape({
+        value: PropTypes.string.isRequired,
+        title: PropTypes.string.isRequired,
+      })
+    ),
+  }),
+  onChange: PropTypes.func.isRequired,
+  data: PropTypes.shape({}),
+};
+
 export default CheckboxOptions;

src/components/util/forms/form-input-area.jsx

@@ -43,6 +43,7 @@ function FormInputArea({
 
 FormInputArea.propTypes = {
   name: PropTypes.string.isRequired,
+  formGroupClasses: PropTypes.string,
   label: PropTypes.string.isRequired,
   placeholder: PropTypes.string,
   value: PropTypes.string,

src/components/util/forms/multiselect-dropdown/multi-dropdown.jsx

@@ -26,7 +26,7 @@ import "./multi-dropdown.scss";
  * @param {Function} props.filterCallback - The callback on search filter.
  * @param {boolean} props.singleSelect - If the dropdown is single select.
  * @param {boolean} props.disableSearch - Disable search option.
- * @param props.error
+ * @param {boolean} props.error - Error.
  * @returns {object} - The multidropdown
  */
 function MultiSelectComponent({

src/components/util/forms/select.jsx

@@ -20,7 +20,7 @@ import { Tooltip } from "react-tooltip";
  * @param {boolean} props.isRequired If the select is required.
  * @param {boolean} props.allowNull Add null option.
  * @param {string | null} props.tooltip Tooltip text. Does not display if null.
- * @param props.disabled
+ * @param {boolean | null} props.disabled Disable the select.
  * @returns {object} The select component.
  */
 function Select({
@@ -104,6 +104,7 @@ function Select({
       {error && <div className="invalid-feedback">{textOnError}</div>}
     </FormGroup>
   );
+  /* eslint-enable jsx-a11y/anchor-is-valid */
 }
 
 Select.propTypes = {
@@ -113,6 +114,8 @@ Select.propTypes = {
       title: PropTypes.string.isRequired,
     })
   ).isRequired,
+  disabled: PropTypes.bool,
+  tooltip: PropTypes.string,
   errors: PropTypes.arrayOf(PropTypes.string),
   label: PropTypes.string.isRequired,
   name: PropTypes.string.isRequired,