3172: Fixed coding standards

Author: tuj

src/app.jsx

@@ -1,4 +1,5 @@
 import React, { useEffect, useRef, useState } from "react";
+import PropTypes from "prop-types";
 import Screen from "./components/screen";
 import ContentService from "./service/content-service";
 import ConfigLoader from "./util/config-loader";
@@ -16,9 +17,9 @@ import constants from "./util/constants";
 /**
  * App component.
  *
- * @param root0
- * @param root0.preview
- * @param root0.previewId
+ * @param {object} props The props.
+ * @param {string | null} props.preview Type of preview to enable.
+ * @param {string | null} props.previewId The id of the entity to preview.
  * @returns {object}
  *   The component.
  */
@@ -235,6 +236,7 @@ function App({ preview, previewId }) {
       statusService.setStatusInUrl();
     }
 
+    /* eslint-disable-next-line consistent-return */
     return function cleanup() {
       logger.info("Unmounting App.");
 
@@ -285,4 +287,9 @@ function App({ preview, previewId }) {
   );
 }
 
+App.propTypes = {
+  preview: PropTypes.string,
+  previewId: PropTypes.string,
+};
+
 export default App;

src/data-sync/pull-strategy.js

@@ -2,7 +2,6 @@ import cloneDeep from 'lodash.clonedeep';
 import isPublished from '../util/isPublished';
 import logger from '../logger/logger';
 import ApiHelper from './api-helper';
-import apiHelper from "./api-helper";
 
 /**
  * PullStrategy.
@@ -414,7 +413,7 @@ class PullStrategy {
   }
 
   async getTemplateData(slide) {
-    return new Promise((resolve, reject) => {
+    return new Promise((resolve) => {
       const templatePath = slide.templateInfo['@id'];
 
       this.apiHelper.getPath(templatePath).then((data) => {
@@ -424,7 +423,7 @@ class PullStrategy {
   }
 
   async getFeedData(slide) {
-    return new Promise((resolve, reject) => {
+    return new Promise((resolve) => {
       if (!slide?.feed?.feedUrl) {
         resolve([]);
       } else {
@@ -436,7 +435,7 @@ class PullStrategy {
   }
 
   async getMediaData(media) {
-    return new Promise((resolve, reject) => {
+    return new Promise((resolve) => {
       this.apiHelper.getPath(media).then((data) => {
         resolve(data);
       });

src/service/content-service.js

@@ -1,7 +1,5 @@
 import sha256 from 'crypto-js/sha256';
 import Base64 from 'crypto-js/enc-base64';
-import { object, string } from 'prop-types';
-import Logger from '../logger/logger';
 import PullStrategy from '../data-sync/pull-strategy';
 import {
   screenForPlaylistPreview,
@@ -88,7 +86,7 @@ class ContentService {
 
     this.stopSyncHandler();
 
-    Logger.log(
+    logger.log(
       'info',
       `Event received: Start data synchronization from ${data?.screenPath}`
     );
@@ -98,7 +96,7 @@ class ContentService {
       );
       this.startSyncing(data.screenPath);
     } else {
-      Logger.log('error', 'Error: screenPath not set.');
+      logger.log('error', 'Error: screenPath not set.');
     }
   }
 
@@ -211,7 +209,7 @@ class ContentService {
   async startPreview(event) {
     const data = event.detail;
     const { mode, id } = data;
-    Logger.log('info', `Starting preview. Mode: ${mode}, ID: ${id}`);
+    logger.log('info', `Starting preview. Mode: ${mode}, ID: ${id}`);
 
     const config = await ConfigLoader.loadConfig();
 
@@ -267,7 +265,7 @@ class ContentService {
         })
       );
     } else {
-      Logger.error(`Unsupported preview mode: ${mode}.`);
+      logger.error(`Unsupported preview mode: ${mode}.`);
     }
   }
 

src/service/token-service.js

@@ -132,11 +132,19 @@ class TokenService {
   checkToken = () => {
     const expiredState = this.getExpireState();
 
-    if ([constants.NO_EXPIRE, constants.NO_ISSUED_AT, constants.NO_TOKEN].includes(expiredState)) {
+    if (
+      [
+        constants.NO_EXPIRE,
+        constants.NO_ISSUED_AT,
+        constants.NO_TOKEN,
+      ].includes(expiredState)
+    ) {
       // Ignore. No token saved in storage.
     } else if (expiredState === constants.TOKEN_EXPIRED) {
       statusService.setError(constants.ERROR_TOKEN_EXPIRED);
-    } else if (expiredState === constants.TOKEN_VALID_SHOULD_HAVE_BEEN_REFRESHED) {
+    } else if (
+      expiredState === constants.TOKEN_VALID_SHOULD_HAVE_BEEN_REFRESHED
+    ) {
       statusService.setError(
         constants.ERROR_TOKEN_VALID_SHOULD_HAVE_BEEN_REFRESHED
       );